Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeViewDragItemsCompletedEventArgs.NewParent spec #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kaiguo
Copy link

@kaiguo kaiguo commented Nov 25, 2019

No description provided.

@kaiguo kaiguo requested a review from a team as a code owner November 25, 2019 20:47
{
...

Object NewParent{ get; };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OldParent isn't necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jevan brought this up as well when I talked to him. Sounds like a good thing to have. Will add it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I tried adding it but then I realized you can select multiple items and drag them together, they don't necessarily share the same parent. OldParentItem is probably not applicable here?

Copy link
Author

@kaiguo kaiguo Nov 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we make OldParent a dictionary of selected items and their parents?

active/TreeView/TreeViewDragItemsCompletedNewParent.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants