-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkbox consistency detailed design PR #35
base: master
Are you sure you want to change the base?
Conversation
Co-Authored-By: Chris Glein <[email protected]>
Co-Authored-By: Chris Glein <[email protected]>
Made the style section go to the top because I'm writing about button style and I wanted alignment with that spec.
Updating with values verified with design.
Updated to the actually agreed visual comp of checkbox.
@YuliKl and @chrisglein FYI. I've updated the spec with latest visual agreement with the design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the Unselected Outline styles be made consistent with the Outline Button styles, if the proposed Button styles are implemented? It appears as if the Filled styles will match the Primary/Accent button styles, including pressed and hover styles.
@mdtauk , I do not believe they will be made exactly the same, though they should feel coherent. That said, the actual outline style is not being looked at right now so I'm unable to answer with confidence. If you have a passion, why don't you propose checkbox/button outline style that aligns so we can take a look, perhaps? |
I posted some thoughts in the Proposal I mentioned Should there be Outlined style and Filled style for all controls including CheckBoxes? I really don't know to be honest.
Both these styles have existed in the past, but were there good reasons one was swapped for the other before? Android has Outlined and Default text fields. Fabric/Fast DNA has Outlined, Default, and Primary buttons. It strikes me that outlined buttons, with a 1px border, would feel a lot more light weight on a form or page. But Filled buttons may stand out a bit better. I don't have a firm preference for one or the other, only that Fast DNA includes all three styles, and Windows UIs have moved between filled and outlined control designs in the past, so there is scope to include both styles - if there can be a simple way to switch for devs. And what the Windows Shell's pick, will probably influence developers choices - but until the modern Shell is in dev's or user's hands - its all just discussion and hope that the design vision comes together. |
No description provided.