Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunCommandv1: uninstall extension before installing it #3531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RunCommandv1: uninstall extension before installing it #3531

wants to merge 1 commit into from
+38 −36

Conversation

LiliDeng
Copy link
Collaborator

No description provided.

squirrelsc
squirrelsc reviewed Nov 25, 2024
View reviewed changes
microsoft/testsuites/vm_extensions/runtime_extensions/run_commandv1.py Outdated
extension_name = "RunCommandv1"
try:
# Delete VM Extension if already present
extension.delete(extension_name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the method to add a flag like ignore_not_found. So the logic can be shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squirrelsc squirrelsc squirrelsc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiliDeng @squirrelsc