Add support for mariner-3.0 in dom0 kernel installer #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smit-gardhariya
requested review from
squirrelsc and
LiliDeng
as code owners
squirrelsc
reviewed
Nov 20, 2024
| target = f"/boot/initrd.img-{current_kernel}" | ||
| link = f"/boot/initrd.img-{new_kernel}" | ||
|
|
||
| if distro == "Microsoft Azure Linux 3.0": |
There was a problem hiding this comment.
Check it by isinstance(node.os, Mariner) and the node.os.information.version. Not use the string.
smit-gardhariya
force-pushed
the
sgardhariya/fix_dom0_kernel_installer
branch
from
0d8f522
to
1eb9a15
Compare
squirrelsc
reviewed
Nov 21, 2024
| @@ -80,6 +81,9 @@ def install(self) -> str: | |||
| uname = node.tools[Uname] | |||
| current_kernel = uname.get_linux_information().kernel_version_raw | |||
|
|
|||
| mariner_version = node.os.information.version | |||
| print(f"mariner_version: {mariner_version}") | |||
There was a problem hiding this comment.
Don't use print in code. The version number should be in debug information already, it doesn't need to be printed again.
There was a problem hiding this comment.
It was just temporary print. I removed it in last push.
smit-gardhariya
force-pushed
the
sgardhariya/fix_dom0_kernel_installer
branch
3 times, most recently
from
3c5d717
to
2a65aca
Compare
pupacha
reviewed
Nov 21, 2024
dom0 image based on mariner 3.0 has different parameter that need to be changed while installing kernel under different file. Add support for it under kernel installer transformer. Signed-off-by: Smit Gardhariya <[email protected]>
smit-gardhariya
force-pushed
the
sgardhariya/fix_dom0_kernel_installer
branch
from
2a65aca
to
ab32653
Compare
pupacha
approved these changes
Nov 21, 2024
LiliDeng
approved these changes
Nov 22, 2024
SRIKKANTH
pushed a commit
that referenced
this pull request
Nov 23, 2024
dom0 image based on mariner 3.0 has different parameter that need to be changed while installing kernel under different file. Add support for it under kernel installer transformer. Signed-off-by: Smit Gardhariya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dom0 image based on mariner 3.0 has different
parameter that need to be changed while installing kernel under different file. Add support for it under kernel installer transformer.