Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes python generation with comment opening/closing tags #5729

Merged
merged 19 commits into from
Nov 13, 2024
Merged

fixes python generation with comment opening/closing tags #5729

merged 19 commits into from
Nov 13, 2024

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Nov 5, 2024 •
edited
Loading

Fixes #5636
Fixes #5744

In summary, the changes in the PR fixes a number of issues in the generator which include.

  • Langauges not supporting untypedNode values do not get return values normalised to binary in the refiners due to a bug in the RemoveUntypedNodePropertyValues functions.
  • Constructors in python do not have quotes cleaned up to properly initialize booleans.
  • parameter for the type parameter is incorrect see Failining integration tests on apisguru::docsusing.net #5744
  • escaping of triple quotes in doc comments in python.

@andrueastman andrueastman mentioned this pull request Nov 7, 2024
Merged
@andrueastman
Copy link
Member Author

Depends on merge of microsoft/kiota-python#402

@andrueastman andrueastman mentioned this pull request Nov 11, 2024
Closed
@andrueastman andrueastman marked this pull request as ready for review November 11, 2024 06:43
@andrueastman andrueastman requested a review from a team as a code owner November 11, 2024 06:43
Ndiritu
Ndiritu previously approved these changes Nov 11, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'kiota'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'microsoft_kiota_frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@andrueastman andrueastman requested a review from baywet November 13, 2024 07:00
@andrueastman andrueastman requested a review from Ndiritu November 13, 2024 07:00
@andrueastman andrueastman merged commit d32a432 into main Nov 13, 2024
214 checks passed
@andrueastman andrueastman deleted the andrueastman/pythonFix branch November 13, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@Ndiritu Ndiritu Awaiting requested review from Ndiritu

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failining integration tests on apisguru::docsusing.net Python - doc comments with """ leads to invalid code
3 participants
@andrueastman @baywet @Ndiritu