Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: create update clients command #5586

Merged
merged 10 commits into from
Oct 14, 2024

Conversation

thewahome
Copy link
Contributor

Closes #5582

@thewahome thewahome requested a review from a team as a code owner October 14, 2024 07:51
Copy link

sonarcloud bot commented Oct 14, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link
Contributor

@fey101 fey101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Musale Martin <[email protected]>
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@fey101 fey101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please test this behavior works to avoid breaking the experience.

@thewahome thewahome requested a review from fey101 October 14, 2024 12:31
@thewahome thewahome merged commit 85f5358 into main Oct 14, 2024
204 of 205 checks passed
@thewahome thewahome deleted the task/extension/create-updateClientsCommand branch October 14, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

Move kiota.updateClients implementation from extension.ts to own command file
3 participants