Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: create various commands #5581

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Conversation

thewahome
Copy link
Contributor

@thewahome thewahome commented Oct 11, 2024

Tasks:

  • Move kiota.openApiExplorer.closeDescription implementation from extension.ts to own command file
  • Move kiota.selectLock implementation from extension.ts to own command file
  • Move kiota.status implementation from extension.ts to own command file
  • Move deeplink uri handling implementation from extension.ts to own command file

@thewahome thewahome requested a review from a team as a code owner October 11, 2024 08:50
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these refactors.

@thewahome thewahome requested a review from a team October 11, 2024 11:09
@thewahome thewahome merged commit fef6ff3 into main Oct 14, 2024
204 of 205 checks passed
@thewahome thewahome deleted the task/extension/create-various-commands branch October 14, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

2 participants