Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: create regeneration commands #5556

Merged
merged 12 commits into from
Oct 11, 2024
Merged

Task: create regeneration commands #5556

merged 12 commits into from
Oct 11, 2024

Conversation

thewahome
Copy link
Contributor

@thewahome thewahome commented Oct 8, 2024 •
edited
Loading

Overview

Notes

  • Creates a regeneration service that can be used by both button and command
  • The properties workspaceGenerationType,clientOrPluginKey and clientOrPluginObject were global to the extension.ts file to enable working across different commands. they've been consolidated into the workspaceGenerationContext as they all change together.

@thewahome thewahome requested a review from a team as a code owner October 8, 2024 11:54
calebkiage
calebkiage previously approved these changes Oct 9, 2024
View reviewed changes
@thewahome thewahome requested review from calebkiage, musale and a team October 11, 2024 07:18
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@thewahome thewahome merged commit 4d671f9 into main Oct 11, 2024
204 of 205 checks passed
@thewahome thewahome deleted the task/extension/create-regeneration-commands branch October 11, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebkiage calebkiage calebkiage approved these changes

@musale musale Awaiting requested review from musale

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move kiota.openApiExplorer.regenerateButton implementation from extension.ts to own command file
3 participants
@thewahome @calebkiage @musale