Fix go scalar collection cast

[lampajr]

Fixes #4380

Given openapi:

    post:
      description: 'Create post'
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: array
              items:
                format: int32
                type: integer

The expected ToPostRequestInformation would be:

// ToPostRequestInformation create post
// returns a *RequestInformation when successful
func (m *PostsRequestBuilder) ToPostRequestInformation(ctx context.Context, body []int32, requestConfiguration *PostsRequestBuilderPostRequestConfiguration) (*i2ae4187f7daee263371cb1c977df639813ab50ffa529013b7437480d1ec0158f.RequestInformation, error) {
	requestInfo := i2ae4187f7daee263371cb1c977df639813ab50ffa529013b7437480d1ec0158f.NewRequestInformationWithMethodAndUrlTemplateAndPathParameters(i2ae4187f7daee263371cb1c977df639813ab50ffa529013b7437480d1ec0158f.POST, "{+baseurl}/posts", m.BaseRequestBuilder.PathParameters)
	if requestConfiguration != nil {
		requestInfo.Headers.AddAll(requestConfiguration.Headers)
		requestInfo.AddRequestOptions(requestConfiguration.Options)
	}
	requestInfo.Headers.TryAdd("Accept", "application/json")
	cast := make([]interface{}, len(body))
	for i, v := range body {
		cast[i] = v
	}
	requestInfo.SetContentFromScalarCollection(ctx, m.BaseRequestBuilder.RequestAdapter, "application/json", cast)
	return requestInfo, nil
}

Note the array cast:

	cast := make([]interface{}, len(body))
	for i, v := range body {
		cast[i] = v
	}

Which is requried as you cannot pass []int32 as []interface{} without this trick.

[lampajr]

@microsoft-github-policy-service agree

[lampajr]

I did not create a new test as there was already existing one checking that specific scenarion: WritesRequestGeneratorBodyForScalarCollection, the issue is that it was not expecting that cast at all.

[lampajr]

Hi @baywet , here my proposal to fix the linked issue.

I was not able to try that locally as I am facing issues while building the project following the steps here, I am getting:

MSBuild version 17.8.5+b5265ef37 for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
  KiotaGenerated -> /home/alampare/repos/kiota/src/Kiota.Generated/bin/Debug/netstandard2.0/KiotaGenerated.dll
CSC : error CS9057: The analyzer assembly '/home/alampare/repos/kiota/src/Kiota.Generated/bin/Debug/netstandard2.0/KiotaGenerated.dll' references version '4.9.0.0' of the compiler, which is newer than the currently running version '4.8.0.0'. [/home/alampare/repos/kiota/src/Kiota.Builder/Kiota.Builder.csproj]

Here you are suggesting to update to the latest SDK but I am already on that one, any other hint? Sorry but I am not .NET expert 🙏

[baywet]

Great work! thanks for putting this together!
About dotnet: what does dotnet --version and dotnet --list-sdks return? what OS are you running things on?
Can you also add a entry to the changelog please?

[lampajr]

About dotnet: what does dotnet --version and dotnet --list-sdks return? what OS are you running things on?

Here all infos:

cat /etc/fedora-release
Fedora release 38 (Thirty Eight)

dotnet --version
8.0.102

dotnet --list-sdks
8.0.102 [/usr/lib64/dotnet/sdk]

Can you also add a entry to the changelog please?

Updated 7089517

[baywet]

latest is 203, but because you're on linux, you might be getting only the 100 patch branch for some reason.
any chance you could use a Codespace for the purpose of testing?

[lampajr]

latest is 203, but because you're on linux, you might be getting only the 100 patch branch for some reason. any chance you could use a Codespace for the purpose of testing?

TBH I never used Codespace, I just tried but it looks like it automatically setups a dev container with .NET 7 instead of .NET 8, maybe there are some configuration in the repo that are forcing that dev container setup (?)

[edit] I also tried to use Fedora 39 locally but the latest sdk version is still the same 8.0.102 [/usr/lib64/dotnet/sdk]

[baywet]

My bad, I forgot to upgrade the dev container configuration when we moved to net 8.
I just put together #4391 for future use.
Now, the CI is failing, which I expected since you couldn't run unit tests locally.
What I suggest you to do here it to:

1. create a temporary branch of this one in your repo
2. merge my changes from 4391 in that temp branch

This way you should be able to run/debug unit tests (I just tried in my own container instance).

Once you have fixes, you can cherry pick the changes from that temp branch onto the current branch.

(or if it's too much gitfu, you can wait for my other PR to get merged, and rebase your branch)

[lampajr]

Thanks @baywet !

I was able to run test using ther devcontainer approach and now they should be fixed ✔️

Is there a way to build the CLI from this branch (download it) and run against my example ? Just to be 100% sure the change works as expected and no regressions are introduced.

[lampajr]

With commit b0337cf I fixed the broken test and I also added some additional checks on other test cases to check whether the cast is generated or not.

[edit] I also rebased on top of main

[baywet]

Thanks for the continuous work on this!

Is there a way to build the CLI from this branch (download it) and run against my example ? Just to be 100% sure the change works as expected and no regressions are introduced.

yes, you can directly run dotnet run -c Release --project src/kiota/kiota.csproj -- <arguments you would pass> to test things out.
You can alternatively edit one of the launch.json profiles (make sure you don't commit it)
I'll hold merging until you give me a confirmation

[lampajr]

yes, you can directly run dotnet run -c Release --project src/kiota/kiota.csproj -- <arguments you would pass> to test things out.

Thanks, it worked! Maybe that's something that could be added in CONTRIBUTING.md as this could be a very useful information, especially for those who are not familiar with dotnet ecosystem.

I'll hold merging until you give me a confirmation

I was able to run it against my use cases and it works fine! @baywet green light fmpov 🚀

[baywet]

Thanks for the contribution!
Please go ahead a open another pr to the contributing file for the guidance we discussed about if you feel it could be valuable to others.