Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs/kiota plugin #4124

Merged
merged 26 commits into from
Mar 26, 2024
Merged

Specs/kiota plugin #4124

merged 26 commits into from
Mar 26, 2024

Conversation

maisarissi
Copy link
Contributor

@maisarissi maisarissi commented Feb 3, 2024

Add support for Kiota to generate plugins.
As AI, Copilot and GPT are becoming more and more the future of developer experience, we should evolve Kiota to generate what is needed for our users to be able to use the Kiota infrastructure (search, endpoint selection, generation, etc.) to generate AI plugins manifests (OpenAI, Copilot, etc.) based on an OpenAPI description.

@baywet
Copy link
Member

baywet commented Feb 27, 2024

@maisarissi I'm not following why we're introducing a whole new bunch of commands for plugins?
Aren't plugins just a different kind of language?

@sebastienlevert
Copy link
Contributor

@baywet We believe plugins / manifests will be different, schema will be different and might evolve in a different way in the future. It felt more natural to introduce new commands.

@baywet
Copy link
Member

baywet commented Feb 27, 2024

I'd like to seem more details in the spec on how those are different from other languages. The spec as it is will require bunch of additional infrastructure for the commands.
We should also think about the integrated experiences like vscode etc.

@maisarissi maisarissi marked this pull request as ready for review February 27, 2024 19:29
@maisarissi maisarissi requested a review from a team as a code owner February 27, 2024 19:29
@maisarissi
Copy link
Contributor Author

@baywet the reason why I believe we should have different commands are because no all parameters will apply to "all languages" in the context of calling manifests other language.
I do know that we have just a few required parameters and that most of the parameters we support are optional, however, for me, optional parameters are the things we are not obligated to provide, but if you provide, it will customize/change the output.
In this scenario, some of the parameters we support for API clients generation such as backing store, className, and others, wouldn't apply to manifests, so people would be able to provide them but they would be ignored. This doesn't sound like a first class experience.

@baywet
Copy link
Member

baywet commented Feb 28, 2024

alright, you've convinced me, keep going and let me know when you want me to review the spec

Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first go! There are missing things (more context, examples of the openai plugins generation) and some inconsistencies in naming, but besides that I think we are in good shape.

specs/scenarios/kiota-config.md Outdated Show resolved Hide resolved
specs/cli/manifest-add.md Outdated Show resolved Hide resolved
specs/cli/manifest-add.md Outdated Show resolved Hide resolved
specs/cli/manifest-add.md Outdated Show resolved Hide resolved
specs/cli/manifest-add.md Outdated Show resolved Hide resolved
specs/cli/manifest-add.md Outdated Show resolved Hide resolved
specs/cli/manifest-add.md Outdated Show resolved Hide resolved
specs/cli/manifest-add.md Outdated Show resolved Hide resolved
specs/cli/manifest-edit.md Outdated Show resolved Hide resolved
specs/cli/manifest-remove.md Outdated Show resolved Hide resolved
@maisarissi
Copy link
Contributor Author

Ready for review @baywet @sebastienlevert @darrelmiller

@maisarissi maisarissi changed the title Specs/kiota plugin Specs/kiota manifest Mar 7, 2024
baywet
baywet previously approved these changes Mar 8, 2024
specs/cli/client-add.md Outdated Show resolved Hide resolved
specs/cli/client-add.md Outdated Show resolved Hide resolved
specs/cli/config-init.md Outdated Show resolved Hide resolved
specs/cli/plugin-add.md Outdated Show resolved Hide resolved
specs/cli/plugin-add.md Show resolved Hide resolved
specs/cli/plugin-add.md Outdated Show resolved Hide resolved
specs/cli/plugin-add.md Outdated Show resolved Hide resolved
specs/cli/plugin-add.md Outdated Show resolved Hide resolved
specs/cli/plugin-add.md Show resolved Hide resolved
specs/cli/plugin-add.md Outdated Show resolved Hide resolved
@maisarissi maisarissi requested a review from baywet March 22, 2024 21:51
specs/cli/plugin-add.md Outdated Show resolved Hide resolved
specs/cli/plugin-add.md Outdated Show resolved Hide resolved
specs/cli/plugin-add.md Outdated Show resolved Hide resolved
specs/cli/plugin-add.md Outdated Show resolved Hide resolved
baywet
baywet previously approved these changes Mar 26, 2024
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with us for all the changes!

@maisarissi maisarissi dismissed stale reviews from sebastienlevert and baywet via b54cb27 March 26, 2024 18:25
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@baywet baywet merged commit bf97766 into main Mar 26, 2024
199 of 200 checks passed
@baywet baywet deleted the specs/kiota-plugin branch March 26, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants