Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- refactoring: all regexes use a generate attribute #3813

Merged
merged 16 commits into from
Nov 30, 2023
Merged

- refactoring: all regexes use a generate attribute #3813

merged 16 commits into from
Nov 30, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Nov 27, 2023 •
edited
Loading

fixes #3797

@baywet baywet self-assigned this Nov 27, 2023
@baywet baywet force-pushed the bugfix/regex-timeout branch 2 times, most recently from 7a2b47a to f828950 Compare November 28, 2023 16:07
baywet added 12 commits November 29, 2023 09:14
@baywet
- refactoring: all regexes use a generate attribute
a8c177d 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- temp: adds regex repro workflow
b2f1762
@baywet
- switches to a lazy matching for vendor cleanup
74ec9b4 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds wf disaptch to regex repro
d513200 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- replaces problematic regex with manual implementation
cfe9c4a 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- downloads descriptions before-hand to limit throttling
a4d0128 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- avoids running the regex twice
38ed9ac 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- increases default regex timeout
d5961fa 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- another bumps of default timeout
33fd9b4 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes concurrency issue with inheritance index
7c5a5b7 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- disables validation rules to reduce log verbosity
71962a7 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes null ref exception in types trimming
02e5698
@baywet baywet force-pushed the bugfix/regex-timeout branch from f6ebbdf to 02e5698 Compare November 29, 2023 14:55
@baywet baywet marked this pull request as ready for review November 29, 2023 17:43
@baywet baywet requested a review from a team as a code owner November 29, 2023 17:43
@baywet baywet enabled auto-merge November 29, 2023 17:43
auto-merge was automatically disabled November 29, 2023 17:49

Pull Request is not mergeable

@baywet baywet enabled auto-merge November 29, 2023 18:16
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.7% 90.7% Coverage
0.0% 0.0% Duplication

auto-merge was automatically disabled November 30, 2023 10:20

Pull Request is not mergeable

@baywet baywet enabled auto-merge November 30, 2023 11:43
@baywet baywet merged commit 1089ee9 into main Nov 30, 2023
174 checks passed
@baywet baywet deleted the bugfix/regex-timeout branch November 30, 2023 12:07
@baywet baywet mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spurious failure for Regex timeout
2 participants
@baywet @andrueastman