Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Include the type which a promise resolves to. #3568

Merged
merged 6 commits into from
Oct 31, 2023
Merged

[FIX] Include the type which a promise resolves to. #3568

merged 6 commits into from
Oct 31, 2023

Conversation

SilasKenneth
Copy link
Member

This commit also includes:

  • Removing the try catch in the request executor and instead just allow
    the exception to be thrown.
  • Refactor the type resolution logic in the PHPConventionService.

@SilasKenneth
[FIX] Include the type which a promise resolves to.
3803437 
This commit also includes:
 - Removing the try catch in the request executor and instead just allow
   the exception to be thrown.
 - Refactor the type resolution logic in the PHPConventionService.
baywet
baywet requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry please?

@baywet baywet linked an issue Oct 24, 2023 that may be closed by this pull request
PHP - Improve auto-completion experience for returned objects #3542
Closed
4 tasks
@SilasKenneth SilasKenneth marked this pull request as ready for review October 25, 2023 09:26
@SilasKenneth SilasKenneth requested a review from a team as a code owner October 25, 2023 09:26
baywet
baywet previously approved these changes Oct 25, 2023
View reviewed changes
andrueastman
andrueastman previously approved these changes Oct 25, 2023
View reviewed changes
@Ndiritu
Copy link
Contributor

Ndiritu commented Oct 25, 2023 •
edited
Loading

@SilasKenneth I'd suggest waiting for the changes on the Kiota core libs to be released before merging.

@baywet baywet dismissed stale reviews from andrueastman and themself via af26dc0 October 27, 2023 12:29
baywet
baywet previously approved these changes Oct 27, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

96.4% 96.4% Coverage
0.0% 0.0% Duplication

@SilasKenneth SilasKenneth merged commit 462a1b5 into main Oct 31, 2023
173 checks passed
@SilasKenneth SilasKenneth deleted the fix/update-php-promise-doc-include-generic-type branch October 31, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP - Improve auto-completion experience for returned objects
4 participants
@SilasKenneth @Ndiritu @andrueastman @baywet