Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- fixes serialization/deserialization for inheritance in dotnet #3544

Merged
merged 2 commits into from
Oct 23, 2023
Merged

- fixes serialization/deserialization for inheritance in dotnet #3544

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
219fb7c
- fixes serialization/deserialization for inheritance in dotnet
baywet Oct 23, 2023
a1ae19e
Update CHANGELOG.md
baywet Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- Fixed missing imports for method parameters that are query parameters.
- Replaces the use of "new" by "override" and "virtual" in CSharp.
baywet marked this conversation as resolved.
Show resolved Hide resolved
- Fixed query parameters type mapping for arrays. [#3354](https://github.com/microsoft/kiota/issues/3354)
- Fixed bug where base64url and decimal types would not be generated properly in Java.
- Fixed bug where symbol name cleanup would not work on forward single quotes characters [#3426](https://github.com/microsoft/kiota/issues/3426).
Expand Down
8 changes: 7 additions & 1 deletion src/Kiota.Builder/Writers/CSharp/CodeMethodWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,13 @@ private static string GetBaseSuffix(bool isConstructor, bool inherits, CodeClass
private void WriteMethodPrototype(CodeMethod code, CodeClass parentClass, LanguageWriter writer, string returnType, bool inherits, bool isVoid)
{
var staticModifier = code.IsStatic ? "static " : string.Empty;
var hideModifier = inherits && code.IsOfKind(CodeMethodKind.Serializer, CodeMethodKind.Deserializer, CodeMethodKind.Factory) ? "new " : string.Empty;
var hideModifier = (inherits, code.Kind) switch
{
(true, CodeMethodKind.Serializer or CodeMethodKind.Deserializer) => "override ",
(false, CodeMethodKind.Serializer or CodeMethodKind.Deserializer) => "virtual ",
(true, CodeMethodKind.Factory) => "new ",
_ => string.Empty
};
var genericTypePrefix = isVoid ? string.Empty : "<";
var genericTypeSuffix = code.IsAsync && !isVoid ? ">" : string.Empty;
var isConstructor = code.IsOfKind(CodeMethodKind.Constructor, CodeMethodKind.ClientConstructor, CodeMethodKind.RawUrlConstructor);
Expand Down
Loading