-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/python imports refactor #2379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you're getting close to completion, can you rebase and remove the suppressions for integration tests that match the issues this PR is closing please? |
samwelkanda
requested review from
Ndiritu,
rkodev,
gavinbarron,
coseguera and
koros
as code owners
March 21, 2023 22:37
baywet
requested changes
Mar 22, 2023
baywet
previously approved these changes
Mar 22, 2023
baywet
reviewed
Mar 22, 2023
baywet
previously approved these changes
Mar 22, 2023
Signed-off-by: Vincent Biret <[email protected]>
baywet
approved these changes
Mar 22, 2023
Kudos, SonarCloud Quality Gate passed! |
This was referenced Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TYPE_CHECKING
variable, we'll have global imports that are only available to IDE's and static type checkers and local imports that will be available during runtime. This approach solves for the dual problem of slow startup time and IDE intellisense.Generation diff:
microsoft/kiota-samples#1762
fixes #2381
fixes #2380
fixes #2293
fixes #2239
fixes microsoftgraph/msgraph-sdk-python#119
fixes microsoftgraph/msgraph-sdk-python#92
fixes microsoftgraph/msgraph-sdk-python#80
fixes microsoftgraph/msgraph-sdk-python#46