Merge pull request #3916 from microsoft/dependabot/github_actions/act…

…ions/download-artifact-4 Bump actions/download-artifact from 3 to 4
microsoft · Dec 15, 2023 · 0c459b0 · 0c459b0
2 parents e771371 + e679671
commit 0c459b0
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/.github/workflows/build-vscode-extension.yml b/.github/workflows/build-vscode-extension.yml
@@ -49,7 +49,7 @@ jobs:
       - run: vsce package
         working-directory: vscode/microsoft-kiota
       - name: Upload artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: vscode-extension
           path: vscode/microsoft-kiota/*.vsix
diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -48,7 +48,7 @@ jobs:
         run: dotnet tool install --global dotnet-reportgenerator-globaltool
       - name: Generate coverage report
         run: reportgenerator -reports:**/coverage.cobertura.xml -targetdir:./reports/coverage
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: coverage
           path: reports/coverage

diff --git a/.github/workflows/idempotency-tests.yml b/.github/workflows/idempotency-tests.yml
@@ -45,7 +45,7 @@ jobs:
       - name: Build
         run: dotnet publish ./src/kiota/kiota.csproj -c Release -p:PublishSingleFile=true -p:PublishReadyToRun=true -o ./publish
         # -p:PublishTrimmed=true -p:PublishAot=true should be enabled to make test run faster, but there are still limitations
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: generator
           path: publish
@@ -77,7 +77,7 @@ jobs:
           - "apisguru::docusign.net"
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: generator
           path: publish
@@ -98,7 +98,7 @@ jobs:
           ORIGINAL="${{ matrix.description }}"
           REPLACED="${ORIGINAL//[-:<>|\*\?\\\/\.]/_}"
           echo "ARTKEY=$REPLACED" >> $GITHUB_OUTPUT
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: idempotency-${{ matrix.language }}-${{ steps.replace_url.outputs.ARTKEY }}

diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
@@ -45,7 +45,7 @@ jobs:
       - name: Build
         run: dotnet publish ./src/kiota/kiota.csproj -c Release -p:PublishSingleFile=true -p:PublishReadyToRun=true -o ./publish
         # -p:PublishTrimmed=true -p:PublishAot=true should be enabled to make test run faster, but there are still limitations
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: generator
           path: publish
@@ -77,7 +77,7 @@ jobs:
           - "apisguru::docusign.net"
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: generator
           path: publish
@@ -144,11 +144,13 @@ jobs:
 
       - id: replace_url
         if: always()
+        # 97 so we don't exceed the 128 character limit for artifact names with the generation-results-typescript prefix
         run: |
-          ORIGINAL="${{ matrix.description }}"
-          REPLACED="${ORIGINAL//[-:<>|\*\?\\\/\.]/_}"
-          echo "ARTKEY=$REPLACED" >> $GITHUB_OUTPUT
-      - uses: actions/upload-artifact@v3
+          $original="${{ matrix.description }}"
+          $replaced=($original -replace "[-:<>|\*\?\\\/\.]", "_").Substring(0, [Math]::Min(97, $original.Length))
+          Write-Output "ARTKEY=$replaced" >> $Env:GITHUB_OUTPUT
+        shell: pwsh
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: generation-results-${{ matrix.language }}-${{ steps.replace_url.outputs.ARTKEY }}