This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
#208 make STJ conditional so only included for < net 6 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompson-tomo
changed the title
There was a problem hiding this comment.
Thanks for this @thompson-tomo
Could you please update the changelog at the repository root as well bump the version so that we release this too?
|
@andrueastman all done. I have just done the license expression via #211 |
thompson-tomo
force-pushed
the
chore/#208_MakeSTJConditional
branch
from
5a118f4 to
7699e57
Compare
baywet
suggested changes
Apr 17, 2024
There was a problem hiding this comment.
Before merge lets bump abstractions dependency with microsoft/kiota-dotnet#220 to avoid any conflicting behaviour
|
Agree, we should also ensure license expression is set on abstractions. Which has been done via microsoft/kiota-dotnet#221 |
thompson-tomo
commented
Apr 18, 2024
baywet
approved these changes
Apr 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make System.Text.Json only necessary on frameworks older than net 6 and hence improve mantainability
Closes #208