Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/generator reduction #219

Merged
merged 17 commits into from
Feb 6, 2024
Merged

Feature/generator reduction #219

merged 17 commits into from
Feb 6, 2024

Conversation

samwelkanda
Copy link
Contributor

Overview

Part of microsoft/kiota#3695

@samwelkanda samwelkanda marked this pull request as ready for review January 31, 2024 13:28
baywet
baywet requested changes Jan 31, 2024
View reviewed changes
kiota_abstractions/default_query_parameters.py Show resolved Hide resolved
kiota_abstractions/request_configuration.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@samwelkanda samwelkanda requested a review from baywet February 1, 2024 10:40
@samwelkanda samwelkanda requested a review from baywet February 1, 2024 15:57
@samwelkanda samwelkanda requested a review from baywet February 5, 2024 13:05
baywet
baywet requested changes Feb 5, 2024
View reviewed changes
kiota_abstractions/default_query_parameters.py Outdated Show resolved Hide resolved
kiota_abstractions/base_request_configuration.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@samwelkanda samwelkanda requested a review from baywet February 5, 2024 14:53
@samwelkanda samwelkanda merged commit 1a6ab20 into main Feb 6, 2024
11 checks passed
@samwelkanda samwelkanda deleted the feature/generator-reduction branch February 6, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@andrueastman andrueastman Awaiting requested review from andrueastman

@SilasKenneth SilasKenneth Awaiting requested review from SilasKenneth

@Ndiritu Ndiritu Awaiting requested review from Ndiritu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samwelkanda @baywet