fix: aligns API surface parameter types

Signed-off-by: Vincent Biret <[email protected]>
microsoft · Oct 11, 2024 · 2107738 · 2107738
1 parent f8617cc
commit 2107738
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/components/http/okHttp/src/main/java/com/microsoft/kiota/http/KiotaClientFactory.java b/components/http/okHttp/src/main/java/com/microsoft/kiota/http/KiotaClientFactory.java
@@ -24,7 +24,6 @@
 import java.time.Duration;
 import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.Collections;
 import java.util.List;
 import java.util.Objects;
 
@@ -47,7 +46,7 @@ private KiotaClientFactory() {}
      */
     @Nonnull public static OkHttpClient.Builder create(@Nonnull final RequestOption[] requestOptions) {
         Objects.requireNonNull(requestOptions, "parameter requestOptions cannot be null");
-        return create(createDefaultInterceptors(Arrays.asList(requestOptions)));
+        return create(createDefaultInterceptors(requestOptions));
     }
 
     /**
@@ -99,7 +98,7 @@ private KiotaClientFactory() {}
      * @return an array of interceptors.
      */
     @Nonnull public static Interceptor[] createDefaultInterceptors() {
-        return createDefaultInterceptors(Collections.emptyList());
+        return createDefaultInterceptors(new RequestOption[0]);
     }
 
     /**
@@ -108,7 +107,7 @@ private KiotaClientFactory() {}
      * @return an array of interceptors.
      */
     @Nonnull public static Interceptor[] createDefaultInterceptors(
-            @Nonnull final List<RequestOption> requestOptions) {
+            @Nonnull final RequestOption[] requestOptions) {
         Objects.requireNonNull(requestOptions, "parameter requestOptions cannot be null");
 
         UrlReplaceHandlerOption uriReplacementOption = null;

diff --git a/components/http/okHttp/src/test/java/com/microsoft/kiota/http/KiotaClientFactoryTest.java b/components/http/okHttp/src/test/java/com/microsoft/kiota/http/KiotaClientFactoryTest.java
@@ -61,11 +61,12 @@ void testDefaultInterceptorsWhenRequestOptionsPassedIn() throws IOException {
         UrlReplaceHandlerOption urlReplaceHandlerOption =
                 new UrlReplaceHandlerOption(new HashMap<>(), false);
 
-        List<RequestOption> options = new ArrayList<>();
+        final ArrayList<RequestOption> options = new ArrayList<>();
         options.add(urlReplaceHandlerOption);
         options.add(retryHandlerOption);
 
-        Interceptor[] interceptors = KiotaClientFactory.createDefaultInterceptors(options);
+        Interceptor[] interceptors =
+                KiotaClientFactory.createDefaultInterceptors(options.toArray(new RequestOption[0]));
         OkHttpClient client = KiotaClientFactory.create(interceptors).build();
         List<Interceptor> clientInterceptors = client.interceptors();
         assertNotNull(interceptors);