Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add retry delay as span attribute in retry handler #180

Merged
merged 3 commits into from
Aug 13, 2024
Merged

feat: Add retry delay as span attribute in retry handler #180

merged 3 commits into from
Aug 13, 2024

Conversation

ohad83
Copy link
Contributor

@ohad83 ohad83 commented Aug 12, 2024

No description provided.

@ohad83 ohad83 requested a review from a team as a code owner August 12, 2024 14:51
baywet
baywet requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Here are a couple of suggestions.
In addition to this, can you also please:

  • bump the version in the user agent options (patch)
  • add an entry in the changelog entry (today's date, patch version, changed)

retry_handler.go Outdated Show resolved Hide resolved
retry_handler.go Outdated Show resolved Hide resolved
@baywet baywet mentioned this pull request Aug 12, 2024
Merged
@ohad83
Copy link
Contributor Author

ohad83 commented Aug 13, 2024

@microsoft-github-policy-service agree company="MIND"

@ohad83 ohad83 requested a review from baywet August 13, 2024 10:25
@ohad83
Copy link
Contributor Author

ohad83 commented Aug 13, 2024

Thanks for the review! Added the requested changes.

baywet
baywet approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet enabled auto-merge August 13, 2024 11:54
@baywet baywet merged commit 3f27fff into microsoft:main Aug 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohad83 @baywet