This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
UriReplacementHandler improvements #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2024 09:38
andrueastman
approved these changes
Apr 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #242 assuming it's ideal for
UriReplacementHandlerto be useable out of the box the way the rest of the handlers are, with the following changes:UriReplacementHandlerrespects options set in theHttpRequestMessagein addition to an option given to it upon construction. A test is also added for this.UriReplacementHandler<UriReplacementHandlerOption>is included as a default handler so it doesn't have to be added manually.