Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Add more information on failures #223

Merged
merged 8 commits into from
Mar 25, 2024
Merged

Conversation

DCourtel
Copy link
Contributor

The SendAsync method will now throw an AggregateException exception instead of an InvalidOperationException when too many retries are made. Each inner exception is an Exception with the HTTP Status Code and the response content, if available.

@DCourtel
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just a couple of sugestions from my end.

Any chance you can also bump the version number in the csproj file as well as add a changelog entry in the changelo.md file at the repository root?

src/Middleware/RetryHandler.cs Outdated Show resolved Hide resolved
src/Middleware/RetryHandler.cs Outdated Show resolved Hide resolved
src/Middleware/RetryHandler.cs Outdated Show resolved Hide resolved
src/Middleware/RetryHandler.cs Outdated Show resolved Hide resolved
@andrueastman andrueastman merged commit ace6591 into microsoft:main Mar 25, 2024
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants