This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
Fixes a bug with CloneAsync extension method.
#175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
baywet
approved these changes
Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CloneAsyncextension method forHttpRequestMessagecallsReadAsStreamAsyncto get the stream contents of a request when cloning the request which will simply return the same underlying stream object of the request message.This therefore means that disposing or seeking the content of the original object will also affect the content of the cloned object as well.
This PR therefore fixes the implementation to use
CopyToAsyncso that a new copy is created to avoid unintended consequences when working with the clone or the original. Tests have been added to validate this as well.