Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds formatting/lint checks #286

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Adds formatting/lint checks #286

merged 2 commits into from
Jul 9, 2024

Conversation

andrueastman
Copy link
Member

This PR is purely cosmetic.

In summary

  • It adds a check in the CI to check formatting by running dotnet format to ensure code is checked in with aligned formatting.
  • Updates sources to align to formatting outlined in the editorconfig

@andrueastman andrueastman requested a review from a team as a code owner July 9, 2024 12:22
@andrueastman andrueastman enabled auto-merge July 9, 2024 12:22
@andrueastman andrueastman disabled auto-merge July 9, 2024 12:25
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@andrueastman andrueastman merged commit 773df94 into main Jul 9, 2024
10 of 11 checks passed
@andrueastman andrueastman deleted the andrueastman/formating branch July 9, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrueastman @baywet