Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes GetAwaiter() from KiotaSerializer.GetStringFromStream method #236

Merged
merged 3 commits into from
May 10, 2024
Merged

Removes GetAwaiter() from KiotaSerializer.GetStringFromStream method #236

merged 3 commits into from
May 10, 2024

Conversation

MihaMarkic
Copy link
Contributor

Resolves #226

@MihaMarkic MihaMarkic requested a review from a team as a code owner May 10, 2024 13:12
baywet
baywet requested changes May 10, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Let's also bump the patch to ensure a swift release.

@MihaMarkic
Copy link
Contributor Author

@baywet Your wish is my command.

baywet
baywet approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes

@baywet baywet enabled auto-merge May 10, 2024 15:37
@baywet baywet merged commit c60d8ed into microsoft:main May 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid using GetAwaiter().GetResult() to prevent deadlocks
2 participants
@MihaMarkic @baywet