Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing DynamicallyAccessedMembers annotation #187

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

hwoodiwiss
Copy link
Contributor

@hwoodiwiss hwoodiwiss commented Feb 3, 2024

This adds a missing DynamicallyAccessedMembers on Configure that means that the DynamicallyAccessedMembers annotation on AddQueryParameters is not fulfilled.

This PR does not have an associated open issue, but is related to microsoft/kiota#4065

Example warning using Microsoft.Kiota.Abstractions 1.7.8

ILC : Trim analysis warning IL2091: Microsoft.Kiota.Abstractions.RequestInformation.Configure<T>(Action`1<RequestConfig
uration`1<!!0>>): 'T' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicProperties' in 'Microsoft
.Kiota.Abstractions.RequestInformation.AddQueryParameters<T>(!!0)'. The generic parameter 'T' of 'Microsoft.Kiota.Abstr
actions.RequestInformation.Configure<T>(Action`1<RequestConfiguration`1<!!0>>)' does not have matching annotations. The
 source value must declare at least the same requirements as those declared on the target location it is assigned to.

This also fixes an issue that prevented IsTrimmable being set in the csproj.

Fixes #188

This adds a missing DynamicallyAccessedMembers on Configure that means that the DynamicallyAccessedMembers annotation on AddQueryParameters is not fulfilled.
baywet
baywet previously approved these changes Feb 3, 2024
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Can you bump the patch version in the csproj and add an entry (Monday) in the changelog please?

Bumps version to 1.7.9 and adds a changelog entry
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

@baywet baywet enabled auto-merge February 4, 2024 13:35
@baywet baywet merged commit 7363f17 into microsoft:main Feb 4, 2024
7 checks passed
@hwoodiwiss hwoodiwiss deleted the hwoodiwiss-fix-missing-annotation branch February 4, 2024 14:51
hwoodiwiss added a commit to hwoodiwiss/kiota-http-dotnet that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project condition for IsTrimmable is incorrect
2 participants