Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure 3XX responses without location header do not throw #272

Closed
baywet opened this issue Mar 21, 2024 · 1 comment · Fixed by #498
Closed

ensure 3XX responses without location header do not throw #272

baywet opened this issue Mar 21, 2024 · 1 comment · Fixed by #498
Assignees
Labels
area:http help wanted Standard GitHub label WIP

Comments

@baywet
Copy link
Member

baywet commented Mar 21, 2024

follow up to microsoft/kiota#4367
and microsoft/kiota#4190

Implement a unit test with a 304 response, no location header, check the request adapter returns null and doesn't throw.
Most likely this line will need to be adapted.
https://github.com/microsoft/kiota-http-dotnet/blob/d960c5fa7f0661ea294b6962be105890a27fe999/src/HttpClientRequestAdapter.cs#L385

@baywet baywet added the Standard GitHub label Issue caused by core project dependency modules or library label Mar 21, 2024
@andrueastman
Copy link
Member

Transferring issue as part of #238

@andrueastman andrueastman transferred this issue from microsoft/kiota-http-dotnet Jul 9, 2024
@andrueastman andrueastman added help wanted Standard GitHub label area:http and removed Standard GitHub label Issue caused by core project dependency modules or library labels Jul 9, 2024
@baywet baywet self-assigned this Dec 18, 2024
@baywet baywet moved this from New📃 to In Progress 🚧 in Kiota Dec 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✔️ in Kiota Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:http help wanted Standard GitHub label WIP
Projects
Status: Done ✔️
Development

Successfully merging a pull request may close this issue.

2 participants