Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement HTTP request adapter #20

Merged
merged 25 commits into from
Apr 8, 2024
Merged

Implement HTTP request adapter #20

merged 25 commits into from
Apr 8, 2024

Conversation

ricardoboss
Copy link
Member

@ricardoboss ricardoboss commented Mar 31, 2024 •
edited
Loading

Fixes #19.

I used https://github.com/microsoft/kiota-http-dotnet as inspiration :D

For now, I have skipped all the middleware because I am not sure how to achieve that with Dart's HTTP library. Also I want to add tests, but that shouldn't block this PR.

@ricardoboss ricardoboss force-pushed the issues/19-http-adapter branch from dff6be9 to ca99136 Compare April 4, 2024 01:42
@ricardoboss
Copy link
Member Author

I am not sure what RetryCAEResponseIfRequired in the C# implementation does. Seemingly it retries the request with a value received from the WWW-Authenticate header. Maybe we should also implement that, but I'd need some guidance there.

@ricardoboss
Copy link
Member Author

Looks like adding middleware can be done in a similar way as its done with the dotnet client: just wrap the client in delegating clients.

I'll work on this branch a bit more and mark this PR as draft for now.

@ricardoboss ricardoboss marked this pull request as draft April 4, 2024 02:01
@ricardoboss ricardoboss mentioned this pull request Apr 7, 2024
Closed
@ricardoboss ricardoboss marked this pull request as ready for review April 7, 2024 13:57
ricardoboss added 22 commits April 7, 2024 15:58
@ricardoboss
Started implementing http client
a0d90e3
@ricardoboss
Implement http client request adapter
fddcd42
@ricardoboss
Added client factory
b9a1ac7
@ricardoboss
Added run config
6fc4abb
@ricardoboss
Make content nullable for requests without body
963e530
@ricardoboss
Use explicit value instead of case name for consistency
9fc8c0a
@ricardoboss
Use less else ifs for better readability
407aeaf
@ricardoboss
Formatting
7c90e6e
@ricardoboss
Include body in request, if any
d576c87
@ricardoboss
Add HTTP headers from info to request
c675d3c
@ricardoboss
Set baseUrl in path parameters instead of query parameters
24bf896
@ricardoboss
Update test with empty request info having no content
7d04366
@ricardoboss
Test and fix sendPrimitive
fb3abd8
@ricardoboss
Don't throw for 3xx response codes
dbf6bd6
@ricardoboss
Make _getMessageFromInfo sync
76ef877
@ricardoboss
Added missing signature for enableBackingStore
c2fcb37
@ricardoboss
Implemented retry handler
1e818ee
@ricardoboss
Added redirect handler (WIP)
644e8c3
@ricardoboss
Use official client wrappers and only provide a custom user agent client
c2ccfaa
@ricardoboss
Ignore generated mocks
a8f674f
@ricardoboss
Update README to include instructions how to run build runner
5f80e77
@ricardoboss
Determine package version at build-time and use it as the user agent …
80feac9 
…version
@ricardoboss ricardoboss force-pushed the issues/19-http-adapter branch from 1b94a27 to 01b4782 Compare April 7, 2024 13:58
@ricardoboss ricardoboss merged commit 192b681 into main Apr 8, 2024
2 checks passed
@ricardoboss ricardoboss deleted the issues/19-http-adapter branch April 8, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kiota_http: HTTP request adapter
2 participants
@ricardoboss @andrueastman