Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Promises generic types #59

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Use Promises generic types #59

merged 5 commits into from
Oct 31, 2023

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Oct 25, 2023

@Ndiritu Ndiritu self-assigned this Oct 25, 2023
@Ndiritu
Copy link
Contributor Author

Ndiritu commented Oct 28, 2023

Pending release of microsoft/kiota-abstractions-php#99

@Ndiritu Ndiritu marked this pull request as ready for review October 28, 2023 03:24
@Ndiritu Ndiritu force-pushed the fix/promises-generics branch from 906dfb3 to 3391392 Compare October 31, 2023 07:55
@Ndiritu Ndiritu requested a review from SilasKenneth October 31, 2023 08:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Ndiritu Ndiritu merged commit 42ba679 into dev Oct 31, 2023
7 checks passed
@Ndiritu Ndiritu deleted the fix/promises-generics branch October 31, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilasKenneth SilasKenneth SilasKenneth approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@zengin zengin Awaiting requested review from zengin

@shemogumbe shemogumbe Awaiting requested review from shemogumbe

Assignees

@Ndiritu Ndiritu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ndiritu @SilasKenneth