Skip to content

Commit

Permalink
Cleanup tests that are skipped in CI:
Browse files Browse the repository at this point in the history
Removes TestConvert() from being skipped as corresponding fix made to v1.6.22
Skip TestContainerSymlinkVolumes() tests as it seems to pass only with containerd/1.7

Signed-off-by: Kirtana Ashok <[email protected]>
  • Loading branch information
kiashok committed Sep 19, 2023
1 parent bc58c27 commit 3865825
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -382,9 +382,7 @@ jobs:
shell: bash
working-directory: src/github.com/containerd/containerd
run: |
# TODO: when https://github.com/containerd/containerd/pull/8691 makes it into the next release (container v1.6.22?), remove the skip
# `-skip` is only available in go1.20
export EXTRA_TESTFLAGS='-timeout=20m -run="[^(TestConvert)]"'
export EXTRA_TESTFLAGS='-timeout=20m'
export GOTEST='gotestsum --format=standard-verbose --debug --'
make integration
Expand All @@ -410,7 +408,7 @@ jobs:
# We skip this test here, until a new release of hcsshim is cut and the one in
# containerd is updated. When the shim is updated in containerd, this test will
# also need to be updated and the special case for windows, removed.
FOCUS="[^TestContainerdRestart$]" make cri-integration
FOCUS="[^(TestContainerdRestart|TestContainerSymlinkVolumes)]" make cri-integration
# Enable these tests once the required JobContainer images are updated.
#
Expand Down

0 comments on commit 3865825

Please sign in to comment.