-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for MAR images to match expected go version
#151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
approved these changes
Aug 7, 2024
mertakman
reviewed
Aug 7, 2024
mertakman
reviewed
Aug 7, 2024
mertakman
reviewed
Aug 7, 2024
mertakman
reviewed
Aug 7, 2024
mertakman
reviewed
Aug 7, 2024
mertakman
requested changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed your code and have a few suggestions for making it cleaner and more precise. These are minor nitpicks, but I believe they'll enhance the overall quality of the code.
mertakman
approved these changes
Aug 9, 2024
Looks good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only intended as a broad check. If we're trying to ship 1.21.5-1 and the image contains 1.210.5, then something went seriously wrong, and this would catch it. This PR changes it from a manual step to an automated one.
Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2510014&view=results
I tested the polling case manually, locally, with versions that don't exist.
The value of this check is limited:
go version
only outputs 1.21.5, so if we're building 1.21.5-2 that replaces 1.21.5-1, it will potentially succeed too early. But, this limitation has always been there--this PR only automates the check, making it clearer that the potential problem exists.Also fixes the pipeline: it was ignoring
runPublishAnnouncement
.