Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for MAR images to match expected go version #151

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

dagood
Copy link
Member

@dagood dagood commented Aug 6, 2024

This is only intended as a broad check. If we're trying to ship 1.21.5-1 and the image contains 1.210.5, then something went seriously wrong, and this would catch it. This PR changes it from a manual step to an automated one.

Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2510014&view=results
I tested the polling case manually, locally, with versions that don't exist.

The value of this check is limited: go version only outputs 1.21.5, so if we're building 1.21.5-2 that replaces 1.21.5-1, it will potentially succeed too early. But, this limitation has always been there--this PR only automates the check, making it clearer that the potential problem exists.

Also fixes the pipeline: it was ignoring runPublishAnnouncement.

@dagood dagood requested a review from a team as a code owner August 6, 2024 22:50
Copy link
Contributor

@mertakman mertakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed your code and have a few suggestions for making it cleaner and more precise. These are minor nitpicks, but I believe they'll enhance the overall quality of the code.

@dagood dagood requested a review from mertakman August 9, 2024 00:05
@mertakman
Copy link
Contributor

Looks good to go

@dagood dagood merged commit e1489dc into main Aug 9, 2024
11 checks passed
@dagood dagood deleted the dev/dagood/image-go-check branch August 9, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically run sanity tests after the release process before announcement
3 participants