gitk: check main window visibility before waiting for it to show #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the main window is already visible when gitk waits for it to become visible, gitk hangs forever. This commit adds a check whether the window is already visible. See https://wiki.tcl-lang.org/page/tkwait+visibility Signed-off-by: Tobias Pietzsch <[email protected]>
|
Oh joy. Something in git/git's CI's fragile dependency management is broken again. Here is a patch by the Git maintainer who wants to "Note that this new URL seems to fail to download", so it's not actually a fix, either. |
mjcheetham
pushed a commit
that referenced
this pull request
Dec 3, 2024
If the main window is already visible when gitk waits for it to become visible, gitk hangs forever. This commit adds a check whether the window is already visible. See https://wiki.tcl-lang.org/page/tkwait+visibility This ports git#944 to `microsoft/git`. for Git. Fixed issue #704.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the main window is already visible when gitk waits for it to become visible, gitk hangs forever.
This commit adds a check whether the window is already visible. See https://wiki.tcl-lang.org/page/tkwait+visibility
This ports git#944 to
microsoft/git. for Git.Fixed issue #704.