-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error handling in prompt_eval and prompt_pipeline #218
Open
tectonia
wants to merge
19
commits into
microsoft:development
Choose a base branch
from
tectonia:bug/207-error-in-pf-do-not-fail-ci-cd
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix error handling in prompt_eval and prompt_pipeline #218
tectonia
wants to merge
19
commits into
microsoft:development
from
tectonia:bug/207-error-in-pf-do-not-fail-ci-cd
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve error handling in flow executions through refactoring flow execution logic for better error management.
Error Handling Improvements:
llmops/common/prompt_eval.py
: Refactored flow execution logic to use a common parameter dictionary and added error handling to log and raise exceptions if the run completes with errors.llmops/common/prompt_pipeline.py
: Refactored flow execution logic to use a common parameter dictionary and added error handling to log and raise exceptions if the run completes with errors.Fixes #207