feat(react-keytips): generate package scaffold #31999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
📊 Bundle size report✅ No changes found |
mainframev
force-pushed
the
feat/keytips-v9
branch
from
c512aab
to
e278867
Compare
fabricteam
reviewed
Jul 15, 2024
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 70 | 80 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 622 | 653 | 5000 | |
| Button | mount | 301 | 315 | 5000 | |
| Field | mount | 1140 | 1138 | 5000 | |
| FluentProvider | mount | 703 | 712 | 5000 | |
| FluentProviderWithTheme | mount | 82 | 89 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 32 | 33 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 70 | 80 | 10 | Possible regression |
| MakeStyles | mount | 880 | 900 | 50000 | |
| Persona | mount | 1783 | 1747 | 5000 | |
| SpinButton | mount | 1416 | 1341 | 5000 | |
| SwatchPicker | mount | 1661 | 1657 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 94 | 78 | 1.21:1 |
| ImageMinimalPerf.default | 232 | 209 | 1.11:1 |
| ChatDuplicateMessagesPerf.default | 163 | 148 | 1.1:1 |
| TextAreaMinimalPerf.default | 305 | 280 | 1.09:1 |
| AlertMinimalPerf.default | 162 | 151 | 1.07:1 |
| ListMinimalPerf.default | 316 | 296 | 1.07:1 |
| StatusMinimalPerf.default | 408 | 380 | 1.07:1 |
| TextMinimalPerf.default | 202 | 189 | 1.07:1 |
| PopupMinimalPerf.default | 364 | 344 | 1.06:1 |
| PortalMinimalPerf.default | 86 | 81 | 1.06:1 |
| IconMinimalPerf.default | 413 | 389 | 1.06:1 |
| HeaderMinimalPerf.default | 213 | 203 | 1.05:1 |
| ListWith60ListItems.default | 383 | 364 | 1.05:1 |
| MenuButtonMinimalPerf.default | 974 | 927 | 1.05:1 |
| AnimationMinimalPerf.default | 309 | 296 | 1.04:1 |
| ChatWithPopoverPerf.default | 205 | 198 | 1.04:1 |
| InputMinimalPerf.default | 546 | 524 | 1.04:1 |
| ProviderMergeThemesPerf.default | 652 | 626 | 1.04:1 |
| DropdownManyItemsPerf.default | 398 | 388 | 1.03:1 |
| ProviderMinimalPerf.default | 201 | 196 | 1.03:1 |
| SplitButtonMinimalPerf.default | 2303 | 2230 | 1.03:1 |
| TooltipMinimalPerf.default | 1278 | 1246 | 1.03:1 |
| BoxMinimalPerf.default | 195 | 192 | 1.02:1 |
| DialogMinimalPerf.default | 452 | 441 | 1.02:1 |
| ReactionMinimalPerf.default | 220 | 215 | 1.02:1 |
| AttachmentSlotsPerf.default | 672 | 664 | 1.01:1 |
| ButtonOverridesMissPerf.default | 642 | 637 | 1.01:1 |
| ChatMinimalPerf.default | 442 | 437 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 701 | 697 | 1.01:1 |
| RadioGroupMinimalPerf.default | 258 | 255 | 1.01:1 |
| CustomToolbarPrototype.default | 1489 | 1472 | 1.01:1 |
| CarouselMinimalPerf.default | 269 | 270 | 1:1 |
| CheckboxMinimalPerf.default | 1134 | 1133 | 1:1 |
| DropdownMinimalPerf.default | 1444 | 1447 | 1:1 |
| EmbedMinimalPerf.default | 1905 | 1910 | 1:1 |
| ListNestedPerf.default | 323 | 324 | 1:1 |
| RosterPerf.default | 1607 | 1610 | 1:1 |
| SegmentMinimalPerf.default | 195 | 195 | 1:1 |
| TreeMinimalPerf.default | 473 | 474 | 1:1 |
| VideoMinimalPerf.default | 441 | 442 | 1:1 |
| AvatarMinimalPerf.default | 112 | 113 | 0.99:1 |
| DatepickerMinimalPerf.default | 3562 | 3595 | 0.99:1 |
| TableManyItemsPerf.default | 1102 | 1112 | 0.99:1 |
| LabelMinimalPerf.default | 212 | 217 | 0.98:1 |
| MenuMinimalPerf.default | 487 | 495 | 0.98:1 |
| TableMinimalPerf.default | 231 | 236 | 0.98:1 |
| HeaderSlotsPerf.default | 457 | 472 | 0.97:1 |
| SkeletonMinimalPerf.default | 190 | 196 | 0.97:1 |
| SliderMinimalPerf.default | 746 | 766 | 0.97:1 |
| ListCommonPerf.default | 374 | 389 | 0.96:1 |
| RefMinimalPerf.default | 112 | 117 | 0.96:1 |
| ToolbarMinimalPerf.default | 531 | 552 | 0.96:1 |
| ButtonMinimalPerf.default | 84 | 88 | 0.95:1 |
| ButtonSlotsPerf.default | 296 | 312 | 0.95:1 |
| CardMinimalPerf.default | 300 | 316 | 0.95:1 |
| FormMinimalPerf.default | 207 | 218 | 0.95:1 |
| FlexMinimalPerf.default | 154 | 164 | 0.94:1 |
| GridMinimalPerf.default | 173 | 185 | 0.94:1 |
| LayoutMinimalPerf.default | 197 | 209 | 0.94:1 |
| DividerMinimalPerf.default | 198 | 213 | 0.93:1 |
| LoaderMinimalPerf.default | 185 | 200 | 0.93:1 |
| AccordionMinimalPerf.default | 80 | 87 | 0.92:1 |
| AttachmentMinimalPerf.default | 81 | 90 | 0.9:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 648 | 625 | 5000 | |
| Breadcrumb | mount | 1702 | 1666 | 1000 | |
| Checkbox | mount | 1708 | 1678 | 5000 | |
| CheckboxBase | mount | 1497 | 1512 | 5000 | |
| ChoiceGroup | mount | 3001 | 2921 | 5000 | |
| ComboBox | mount | 669 | 672 | 1000 | |
| CommandBar | mount | 6571 | 6544 | 1000 | |
| ContextualMenu | mount | 11948 | 12017 | 1000 | |
| DefaultButton | mount | 811 | 800 | 5000 | |
| DetailsRow | mount | 2269 | 2250 | 5000 | |
| DetailsRowFast | mount | 2229 | 2259 | 5000 | |
| DetailsRowNoStyles | mount | 2026 | 2052 | 5000 | |
| Dialog | mount | 2834 | 2775 | 1000 | |
| DocumentCardTitle | mount | 244 | 238 | 1000 | |
| Dropdown | mount | 2001 | 2050 | 5000 | |
| FocusTrapZone | mount | 1151 | 1147 | 5000 | |
| FocusZone | mount | 1080 | 1087 | 5000 | |
| GroupedList | mount | 42318 | 42089 | 2 | |
| GroupedList | virtual-rerender | 20223 | 20304 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 52206 | 51786 | 2 | |
| GroupedListV2 | mount | 232 | 227 | 2 | |
| GroupedListV2 | virtual-rerender | 214 | 214 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 237 | 230 | 2 | |
| IconButton | mount | 1160 | 1141 | 5000 | |
| Label | mount | 344 | 350 | 5000 | |
| Layer | mount | 2740 | 2713 | 5000 | |
| Link | mount | 398 | 399 | 5000 | |
| MenuButton | mount | 961 | 1003 | 5000 | |
| MessageBar | mount | 21149 | 21213 | 5000 | |
| Nav | mount | 2061 | 2071 | 1000 | |
| OverflowSet | mount | 793 | 780 | 5000 | |
| Panel | mount | 1769 | 1796 | 1000 | |
| Persona | mount | 748 | 725 | 1000 | |
| Pivot | mount | 919 | 880 | 1000 | |
| PrimaryButton | mount | 904 | 935 | 5000 | |
| Rating | mount | 4751 | 4649 | 5000 | |
| SearchBox | mount | 903 | 902 | 5000 | |
| Shimmer | mount | 1928 | 2006 | 5000 | |
| Slider | mount | 1374 | 1350 | 5000 | |
| SpinButton | mount | 3005 | 2976 | 5000 | |
| Spinner | mount | 398 | 394 | 5000 | |
| SplitButton | mount | 1879 | 1894 | 5000 | |
| Stack | mount | 420 | 421 | 5000 | |
| StackWithIntrinsicChildren | mount | 856 | 888 | 5000 | |
| StackWithTextChildren | mount | 2747 | 2752 | 5000 | |
| SwatchColorPicker | mount | 6413 | 6402 | 5000 | |
| TagPicker | mount | 1462 | 1473 | 5000 | |
| Text | mount | 401 | 391 | 5000 | |
| TextField | mount | 946 | 926 | 5000 | |
| ThemeProvider | mount | 839 | 836 | 5000 | |
| ThemeProvider | virtual-rerender | 573 | 576 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1302 | 1300 | 5000 | |
| Toggle | mount | 625 | 614 | 5000 | |
| buttonNative | mount | 189 | 197 | 5000 |
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Jul 15, 2024
mainframev
force-pushed
the
feat/keytips-v9
branch
2 times, most recently
from
70aaa6e
to
6976ce0
Compare
Hotell
reviewed
Jul 16, 2024
...ponents/react-shared-contexts/library/src/CustomStyleHooksContext/CustomStyleHooksContext.ts
Outdated
Show resolved
Hide resolved
...rc/generators/react-library/lib/yarn nx g @fluentui/workspace-plugin:react-library --dry-run
Outdated
Show resolved
Hide resolved
packages/react-components/react-keytips-preview/library/src/index.ts
Outdated
Show resolved
Hide resolved
mainframev
force-pushed
the
feat/keytips-v9
branch
from
0fad0ed
to
0a33a94
Compare
fabricteam
reviewed
Jul 16, 2024
mainframev
force-pushed
the
feat/keytips-v9
branch
from
fd6a0bd
to
1d2a8e8
Compare
mainframev
changed the title
mainframev
force-pushed
the
feat/keytips-v9
branch
5 times, most recently
from
30ef67c
to
7c89db4
Compare
mainframev
force-pushed
the
feat/keytips-v9
branch
from
7c89db4
to
b7d072c
Compare
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated basic package setup for upcoming Keytips component.