refactor(react-interactive-tab): export all types and hooks from barrel file #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokirpa
added
the
@fluent-contrib/react-interactive-tab
dmytrokirpa
reviewed
Nov 1, 2024
| InteractiveTabProps, | ||
| InteractiveTabSlots, | ||
| InteractiveTabState, | ||
| InteractiveTabInternalSlots, |
There was a problem hiding this comment.
I don't think we should export InteractiveTabInternalSlots, as it's Internal and the core react-tabs package doesn't export TabInternalSlots as well. Other than that, looks good to me!
|
@soniaboller, thank you for your contribution. To ensure a release is triggered post-merger, kindly add a "change file" to the PR. This can be accomplished by executing |
dmytrokirpa
approved these changes
Nov 1, 2024
|
@microsoft-github-policy-service agree company="Microsoft" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
barrel file for InteractiveTab should export all types and hooks, in addition to the component