Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitokic/10102024/synapse 34 migration #167

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Mitokic/10102024/synapse 34 migration #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2332c7
update set_run_info to accomodate differnt synapse mount path types i…
mitokic Oct 10, 2024
5a72f07
update grid search
mitokic Oct 10, 2024
c22f29a
testing
mitokic Oct 10, 2024
2a7d70b
testing
mitokic Oct 10, 2024
59066d6
testing
mitokic Oct 14, 2024
5c79652
formatting
mitokic Oct 14, 2024
d3dbf41
ensemble model fix
mitokic Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: finnts
Title: Microsoft Finance Time Series Forecasting Framework
Version: 0.4.0.9006
Version: 0.4.0.9007
Authors@R:
c(person(given = "Mike",
family = "Tokic",
Expand Down
3 changes: 2 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# finnts 0.4.0.9006 (DEVELOPMENT VERSION)
# finnts 0.4.0.9007 (DEVELOPMENT VERSION)

## Improvements

Expand All @@ -9,6 +9,7 @@
- Automatically condense large forecasts (+10k time series) into smaller amount of files to make it easier to read forecast outputs
- Improved weighted MAPE calculation across all time series
- Changed default for box_cox argument in `prep_data()` to FALSE
- Support for spark version 3.4 in Azure Synapse/Fabric

## Bug Fixes

Expand Down
3 changes: 2 additions & 1 deletion R/ensemble_models.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,8 @@ ensemble_models <- function(run_info,
avail_arg_list <- list(
"train_data" = prep_ensemble_tbl %>% dplyr::select(-Train_Test_ID),
"model_type" = "ensemble",
"pca" = FALSE
"pca" = FALSE,
"multistep" = FALSE
)

# get specific model spec
Expand Down
4 changes: 2 additions & 2 deletions R/run_info.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,15 @@ set_run_info <- function(experiment_name = "finn_fcst",
current_log_df <- tibble::tibble(
experiment_name = experiment_name,
run_name = run_name,
path = gsub("synfs/\\d+", "synfs", path), # remove synapse id to prevent issues
path = gsub("synfs(/notebook)?/\\d+", "synfs", path), # remove synapse id to prevent issues
data_output = data_output,
object_output = object_output
) %>%
data.frame()

prev_log_df <- log_df %>%
dplyr::select(colnames(current_log_df)) %>%
dplyr::mutate(path = gsub("synfs/\\d+", "synfs", path)) %>% # remove synapse id to prevent issues
dplyr::mutate(path = gsub("synfs(/notebook)?/\\d+", "synfs", path)) %>% # remove synapse id to prevent issues
data.frame()

if (hash_data(current_log_df) != hash_data(prev_log_df)) {
Expand Down
Loading