Add publish pipeline #344
Add publish pipeline #344
Conversation
| command: push | ||
| nuGetFeedType: external | ||
| publishFeedCredentials: 'DurableTask org NuGet API Key' | ||
| packagesToPush: '$(System.DefaultWorkingDirectory)/drop/Microsoft.DurableTask.Abstractions.*.nupkg;!$(System.DefaultWorkingDirectory)/**/*.symbols.nupkg' # Despite this being a custom command, we need to keep this for 1ES validation |
There was a problem hiding this comment.
!$(System.DefaultWorkingDirectory)/**/*.symbols.nupkg needs to be included?Weird - I don't believe we produce those. Instead we produce.snupkg` (which I believe will automatically be included when a nupkg is pushed)
There was a problem hiding this comment.
The /**/*.symbols.nupkg bit appears here because the default value for packagesToPush includes it, and I was just modifying that default template. You're right, we should be able to remove it; let me know into that
| targetPath: $(System.DefaultWorkingDirectory)/drop | ||
| steps: | ||
| - task: 1ES.PublishNuget@1 | ||
| displayName: 'NuGet push (Microsoft.DurableTask.Client)' |
There was a problem hiding this comment.
Splitting these all into separate jobs looks quite cumbersome, especially now we will need to edit this every time a new project is added.
In legacy release, I worked around this by using the dotnet CLI for pushing to nuget.org. Did you try using useDotNetTask: true and allowPackageConflicts: true?
Hopefully with those 2 inputs this can be consolidated down to a single job.
There was a problem hiding this comment.
Oh, I don't recall seeing a useDotNetTask option, perhaps that's what I need. I can give it a go.
The key issue is that the 1ES nuget release task has a limitation of not allowing package conflicts, so if this setting allows me to go back to the original nuget release task, then this would be it
|
|
||
| extends: | ||
| template: v1/1ES.Official.PipelineTemplate.yml@1es | ||
| parameters: |
There was a problem hiding this comment.
Consider adding:
| parameters: | |
| parameters: | |
| featureFlags: | |
| sdlNugetPathOptimization: true |
There was a problem hiding this comment.
Can you tell me a bit more about what this does? I'd like to include some context as an inline comment
There was a problem hiding this comment.
I am not sure what it all does exactly. SDL is something 1ES team controls and their nuget release docs recommended adding it. Its probably fine to omit though
This PR adds a package publishing pipeline to automate releases to ADO and NuGet