Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete implicit operation #178

Merged
merged 9 commits into from
Aug 28, 2023
Merged

Add delete implicit operation #178

merged 9 commits into from
Aug 28, 2023

Conversation

jviau
Copy link
Member

@jviau jviau commented Aug 25, 2023

This PR introduces an implicit delete operation when deriving from TaskEntity<TState>. This operation will null out the entities state, effectively deleting the entity.

sebastianburckhardt
sebastianburckhardt approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@sebastianburckhardt sebastianburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on offline discussion the current design is sufficient, we may add another form of deletion (PurgeEntity) as a client-issued operation later.

@jviau jviau merged commit a446909 into microsoft:feature/entities Aug 28, 2023
2 checks passed
@jviau jviau deleted the entity-delete branch August 28, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianburckhardt sebastianburckhardt sebastianburckhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jviau @sebastianburckhardt