simplify method resolution of terminate

microsoft · May 22, 2024 · 9d6b693 · 9d6b693
1 parent 76a2972
commit 9d6b693
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Client/Core/DurableTaskClient.cs b/src/Client/Core/DurableTaskClient.cs
@@ -216,7 +216,7 @@ public virtual Task TerminateInstanceAsync(string instanceId, CancellationToken
     /// <inheritdoc cref="TerminateInstanceAsync(string, TerminateInstanceOptions, CancellationToken)"/>
     public virtual Task TerminateInstanceAsync(string instanceId, object? output = null, CancellationToken cancellation = default)
     {
-        TerminateInstanceOptions? options = output is null ? null : new() { Output = output };
+        TerminateInstanceOptions? options = new() { Output = output };
         return this.TerminateInstanceAsync(instanceId, options, cancellation);
     }
 
@@ -252,7 +252,7 @@ public virtual Task TerminateInstanceAsync(string instanceId, object? output = n
     /// termination of the orchestration once enqueued.
     /// </param>
     /// <returns>A task that completes when the terminate message is enqueued.</returns>
-    public virtual Task TerminateInstanceAsync(string instanceId, TerminateInstanceOptions? options = null, CancellationToken cancellation = default)
+    public virtual Task TerminateInstanceAsync(string instanceId, TerminateInstanceOptions options, CancellationToken cancellation = default)
         => throw new NotSupportedException($"{this.GetType()} does not support orchestration termination.");
 
     /// <inheritdoc cref="SuspendInstanceAsync(string, string, CancellationToken)"/>