Disable api calls #851
Open
Disable api calls #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/script/acquisition-sdk.ts
Outdated
| @@ -58,14 +58,15 @@ export class AcquisitionStatus { | |||
| } | |||
|
|
|||
| export class AcquisitionManager { | |||
| private readonly BASER_URL_PART = "appcenter.ms" | |||
There was a problem hiding this comment.
;, and check other places.
src/test/acquisition-sdk.ts
Outdated
| assert.strictEqual(acquisitionSdk.AcquisitionManager.apiCallsDisabled, false); | ||
| })) | ||
|
|
||
| acquisition.reportStatusDownload(templateCurrentPackage, ((error: Error, parameter: void): void => { |
There was a problem hiding this comment.
what about queryUpdateWithCurrentPackage?
| configuration = { ...configuration, serverUrl: "https://codepush.appcenter.ms" } | ||
| var acquisition = new acquisitionSdk.AcquisitionManager(new mockApi.CustomResponseHttpRequester(invalidJsonResponse), configuration); | ||
|
|
||
| acquisition.queryUpdateWithCurrentPackage(templateCurrentPackage, (error: Error, returnPackage: acquisitionSdk.RemotePackage | acquisitionSdk.NativeUpdateNotification) => { |
There was a problem hiding this comment.
what about reportStatusDeploy and reportStatusDownload?
| private _appVersion: string; | ||
| private _clientUniqueId: string; | ||
| private _deploymentKey: string; | ||
| private _httpRequester: Http.Requester; | ||
| private _ignoreAppVersion: boolean; | ||
| private _serverUrl: string; | ||
| private _publicPrefixUrl: string = "v0.1/public/codepush/"; | ||
|
|
||
| private static _apiCallsDisabled: boolean = false; | ||
| constructor(httpRequester: Http.Requester, configuration: Configuration) { |
src/test/acquisition-sdk.ts
Outdated
| }); | ||
|
|
||
| acquisition.queryUpdateWithCurrentPackage(templateCurrentPackage, (error: Error, returnPackage: acquisitionSdk.RemotePackage | acquisitionSdk.NativeUpdateNotification) => { | ||
| assert.notStrictEqual(returnPackage, null) |
| assert.strictEqual(acquisitionSdk.AcquisitionManager.apiCallsDisabled, true); | ||
| }); | ||
|
|
||
| acquisition.reportStatusDeploy(templateCurrentPackage, acquisitionSdk.AcquisitionStatus.DeploymentSucceeded, "1.5.0", mockApi.validDeploymentKey, ((error: Error, parameter: void): void => { |
There was a problem hiding this comment.
before calling this method apiCallsDisabled is already true as a result of previous method invocation. We need to refresh the context before testing this and the next method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented feature for stopping api calls from being sent after unsuccessful response. This behavior is aligned with other appcenter SDKs. Disabling of api calls occurs only per session after first failed request.
Related PRs or issues
AB#107980