Skip to content

Commit

Permalink
[c#] Be explicit about codegen target dependencies
Browse files Browse the repository at this point in the history
The MSBuild target `BondCompileCs` depends on the target `BondCodegenCs`
to populate the `@_BondCodegenWithDefaultOptions` item. It is currently
always running after `BondCompileCs` since it comes after that target in
the .targets file. Adding an explicit `DependsOnTargets="BondCodegenCs"`
is more robust.
  • Loading branch information
chwarr authored Jun 29, 2020
1 parent 890ec38 commit dd7b47d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cs/build/nuget/Common.targets
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@
-->
<Target Name="BondCompileCs"
BeforeTargets="CoreCompile"
DependsOnTargets="BondCodegenCs"
Condition="'@(BondCodegen)' != ''">

<ItemGroup>
Expand Down

0 comments on commit dd7b47d

Please sign in to comment.