-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Prometheus exporter in HAProxy #12056
base: fasttrack/3.0
Are you sure you want to change the base?
Support for Prometheus exporter in HAProxy #12056
Conversation
Enabled compilation flag USE_PROMEX to support prometheus exporter in HAProxy. Signed-off-by: Kshitiz Godara <[email protected]>
9597439
to
ad0e178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes: #12011
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,7 +1,7 @@ | |||
Summary: A fast, reliable HA, load balancing, and proxy solution. | |||
Name: haproxy | |||
Version: 2.9.11 | |||
Release: 1%{?dist} | |||
Release: 2%{?dist} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgodara912 why did we drive this through fast-track? Please target feature change PRs to 3.0-dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jslobodzian for the review, from the workitem comment, I felt that it is required for February release, which is within a week, so raised review for fast-track. I will check with Eric once if it is fine to go with 3.0-dev.
Enabled compilation flag USE_PROMEX to support prometheus exporter in HAProxy.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology
haproxy -vv