Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Prometheus exporter in HAProxy #12056

Open
wants to merge 2 commits into
base: fasttrack/3.0
Choose a base branch
from

Conversation

kgodara912
Copy link

@kgodara912 kgodara912 commented Jan 24, 2025

Enabled compilation flag USE_PROMEX to support prometheus exporter in HAProxy.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

  • This PR adds support for Prometheus exporter in HAProxy module as per the customer requirement.
Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • Pipeline build id: 718262
  • Checked that installed package has flag USE_PROMEX=1 enabled by running haproxy -vv
$ haproxy -vv
HAProxy version 2.9.11-3c54f78 2024/09/19 - https://haproxy.org/
...
  OPTIONS = USE_GETADDRINFO=1 USE_OPENSSL=1 USE_ZLIB=1 USE_SYSTEMD=1 USE_PROMEX=1 USE_PCRE2=1
Feature list : ... +PROMEX

...
Built with the Prometheus exporter as a service
...
Available services : prometheus-exporter
...

Enabled compilation flag USE_PROMEX to support prometheus exporter
in HAProxy.

Signed-off-by: Kshitiz Godara <[email protected]>
@kgodara912 kgodara912 force-pushed the kgodara/haproxy/haproxy_prometheus_support branch from 9597439 to ad0e178 Compare January 24, 2025 04:30
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes: #12011

Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

image

@@ -1,7 +1,7 @@
Summary: A fast, reliable HA, load balancing, and proxy solution.
Name: haproxy
Version: 2.9.11
Release: 1%{?dist}
Release: 2%{?dist}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgodara912 why did we drive this through fast-track? Please target feature change PRs to 3.0-dev.

Copy link
Author

@kgodara912 kgodara912 Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jslobodzian for the review, from the workitem comment, I felt that it is required for February release, which is within a week, so raised review for fast-track. I will check with Eric once if it is fine to go with 3.0-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants