Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ceph CVE Fixes - Removing "jaegertracing/opentelemetry-cpp" as it was not being built #11999

Open
wants to merge 3 commits into
base: fasttrack/3.0
Choose a base branch
from

Conversation

cyberbandya007
Copy link
Contributor

@cyberbandya007 cyberbandya007 commented Jan 19, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Removing the opentelemetry-cpp module from the ceph package as it is not being built.

Change Log
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

@cyberbandya007
Copy link
Contributor Author

cyberbandya007 commented Jan 19, 2025

As per the discussion with Jon, since we are not building this subsystem, removing them from the package before build time to confirm the CVE fixes.

The following log in the rpmbuild also confirms that this sybsystem was not getting built -

time="2025-01-10T23:49:18Z" level=debug msg="-- exclude following files under src: .js;.css;.tox;python-common/build;erasure-code/jerasure/jerasure;erasure-code/jerasure/gf-complete;rocksdb;googletest;spdk;xxHash;isa-l;zstd;crypto/isa-l/isa-l_crypto;blkin;dmclock;seastar;fmt;c-ares;spawn;pybind/mgr/rook/rook-client-python;s3select;libkmip;arrow;utf8proc;jaegertracing/opentelemetry-cpp"

@cyberbandya007 cyberbandya007 changed the title Ceph CVE Fixes - Removing modules not being built Ceph CVE Fixes - Removing "jaegertracing/opentelemetry-cpp" as it was not being built Jan 21, 2025
@@ -2000,6 +2004,9 @@ exit 0


%changelog
* Tue Jan 01 2025 Sandeep Karambelkar <[email protected]> - 18.2.2-3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What CVE's is this fixing? Best Practice is to state this in the PR Commit title and explain the implementation details in the commit details section.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then close out the PR's that are not needed so it's clear on our end which ones to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants