Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch vim to resolve CVE-2024-43802 #10681

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Patch vim to resolve CVE-2024-43802 #10681

merged 3 commits into from
Oct 17, 2024

Conversation

sameluch
Copy link
Contributor

@sameluch sameluch commented Oct 9, 2024 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

What does the PR accomplish, why was it needed?
Patch CVE-2024-43802 within the vim package on Azure Linux 3.0.

Change Log
  • Add patch for CVE-2024-43802
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

@sameluch sameluch requested a review from a team as a code owner October 9, 2024 23:08
christopherco
christopherco requested changes Oct 10, 2024
View reviewed changes
SPECS/vim/CVE-2024-43802.patch Outdated Show resolved Hide resolved
rikenm1
rikenm1 requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@rikenm1 rikenm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sam, BuildAndtest Pr checked failed. It failed because one or more Ptests failed. Can you check to see if this failure has been happening for a while or if it is because of this new change.

@jslobodzian jslobodzian merged commit 65fa19d into fasttrack/3.0 Oct 17, 2024
11 of 15 checks passed
@jslobodzian jslobodzian deleted the sammeluch/CVE-2024-43802 branch October 17, 2024 18:53
CBL-Mariner-Bot pushed a commit that referenced this pull request Oct 17, 2024
@sameluch @CBL-Mariner-Bot
Patch vim to resolve CVE-2024-43802 (#10681)
2df0167 
Co-authored-by: jslobodzian <[email protected]>
(cherry picked from commit 65fa19d)
@CBL-Mariner-Bot CBL-Mariner-Bot mentioned this pull request Oct 17, 2024
Merged
@CBL-Mariner-Bot
Copy link
Collaborator

Auto cherry-pick results:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=659335&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikenm1 rikenm1 rikenm1 requested changes

@christopherco christopherco christopherco approved these changes

@jslobodzian jslobodzian jslobodzian approved these changes

Assignees
No one assigned
Labels
fasttrack/3.0 Packaging security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sameluch @CBL-Mariner-Bot @jslobodzian @christopherco @rikenm1 @mfrw