Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Customizer: Allow omitting disk maxSize and partition start. #10383

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

cwize1
Copy link
Contributor

@cwize1 cwize1 commented Sep 6, 2024

Allow the partition start to be inferred from the previous partition's end. Also, allow the disk's maxSize to be inferred from the size/end of the last partition.

In addition, since the partition start can now be omitted, require the partitions to be specified in order. Fortunately, most users do this anyway.


Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Does this affect the toolchain?

NO

Test Methodology
  • Added tests.

Allow the partition start to be inferred from the previous partition's
end. Also, allow the disk's maxSize to be inferred from the size/end of
the last partition.

In addition, since the partition start can now be omitted, require the
partitions to be specified in order. Fortunately, most users do this
anyway.
@cwize1 cwize1 requested a review from a team as a code owner September 6, 2024 21:51
@cwize1 cwize1 merged commit e501adb into 3.0-dev Sep 11, 2024
12 checks passed
@cwize1 cwize1 deleted the user/chrisgun/micOmitStartMaxSize branch September 11, 2024 19:14
@cwize1 cwize1 mentioned this pull request Sep 11, 2024
12 tasks
cwize1 added a commit that referenced this pull request Sep 11, 2024
#10404 and #10383 were merged at a similar time but had a hidden merge conflict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants