kernel-uki: drop dbus in initrd #10311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jozzsi Change looks good to me. No issue in our initrd |
microsoft-github-policy-service
bot
added
documentation
trungams
requested changes
Sep 11, 2024
trungams
approved these changes
Sep 11, 2024
Camelron
approved these changes
Sep 11, 2024
rlmenge
reviewed
Sep 11, 2024
|
@jozzsi there seems to be a conflict as another PR that went in also bumped the kernel version. Could you bump the release version to |
Sorry, but this process is too much overhead for me as now it also needs a rebase. Feel free to close this PR or take it over. |
|
No problem. I can take over the PR. Thank you for the change! |
trungams
changed the base branch from
3.0-dev
to
tvuong/3.0-dev/uki-remove-dbus
trungams
merged commit fa3bcb0
into
microsoft:tvuong/3.0-dev/uki-remove-dbus
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
dbus is known to have limitations and usually only gets included for either networking or bluetooth support.
Please see dracutdevs/dracut#2378 and dracut-ng/dracut-ng#60 .
Does this affect the toolchain?
YES
Test Methodology
@ddstreet @trungams - would you please be able to help testing this change given the concerns ? If dbus indeed can be dropped, than it should be dropped and I can finish up the PR with the rest of the changes.