TestApp build with CodeQL analysis

.azurepipelines/build-test-app-android.yml

@@ -0,0 +1,58 @@
+pr:
+- master
+
+pool:
+  vmImage: macos-latest
+
+jobs:
+- job:
+  displayName: Build and CodeQL TestApp Android
+  steps:
+  - checkout: self
+    submodules: recursive
+
+  - task: CodeQL3000Init@0
+    displayName: CodeQL Initialize
+
+  - task: NodeTool@0
+    displayName: 'Use Node 16.x'
+    inputs:
+      versionSpec: 16.x
+
+  - task: JavaToolInstaller@0
+    inputs:
+      versionSpec: '11'
+      jdkArchitectureOption: 'x64'
+      jdkSourceOption: 'PreInstalled'
+    displayName: 'Use Java 11'
+
+  - task: Bash@3
+    displayName: Run update-npm-packages script
+    inputs:
+      filePath: TestApp/update-npm-packages.sh
+      arguments: "android"
+      workingDirectory: TestApp
+
+  - task: Bash@3
+    displayName: Run install-ndk-version script
+    inputs:
+      filePath: TestApp/install-ndk-version.sh
+      arguments: "20"
+      workingDirectory: TestApp
+
+  - task: Bash@3
+    displayName: Run set-ndk-version script
+    inputs:
+      filePath: TestApp/set-ndk-version.sh
+      workingDirectory: TestApp
+
+  - task: Gradle@3
+    displayName: Build TestApp
+    inputs:
+      gradleWrapperFile: TestApp/android/gradlew
+      workingDirectory: TestApp/android
+      tasks: assembleRelease
+      publishJUnitResults: false
+
+  - task: CodeQL3000Finalize@0
+    displayName: CodeQL Finalize

TestApp/install-ndk-version.sh

@@ -0,0 +1,38 @@
+#!/bin/bash
+
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License.
+
+# Download and install the specified version of the Android NDK
+
+# Check if the NDK_MAJOR_VERSION argument is provided
+if [ -z "$1" ]; then
+    echo "NDK version is not provided"
+    return 1
+fi
+
+# Check if ANDROID_HOME is defined
+if [ -z "$ANDROID_HOME" ]; then
+    echo "ANDROID_HOME is not defined"
+    return 1
+fi
+
+NDK_MAJOR_VERSION="$1"
+ANDROID_NDK_HOME="$ANDROID_HOME/ndk-bundle"
+
+# Download the specified version of the Android NDK
+echo "Download Android NDK version $NDK_MAJOR_VERSION"
+curl -o android-ndk-r$NDK_MAJOR_VERSION-darwin-x86_64.zip https://dl.google.com/android/repository/android-ndk-r$NDK_MAJOR_VERSION-darwin-x86_64.zip
+
+# Unzip the downloaded NDK zip file into a directory
+unzip android-ndk-r$NDK_MAJOR_VERSION-darwin-x86_64.zip -d android-ndk-r$NDK_MAJOR_VERSION
+
+# Remove any existing NDK installation in ANDROID_HOME/ndk-bundle and replace it with the downloaded one
+echo "Copy NDK to $ANDROID_NDK_HOME"
+rm -rf $ANDROID_NDK_HOME
+cp -r ./android-ndk-r$NDK_MAJOR_VERSION/android-ndk-r$NDK_MAJOR_VERSION $ANDROID_NDK_HOME
+
+# Clean up by removing the unzipped files and the downloaded zip file
+rm -rf android-ndk-r$NDK_MAJOR_VERSION android-ndk-r$NDK_MAJOR_VERSION-darwin-x86_64.zip
+
+echo "NDK $NDK_MAJOR_VERSION is installed to $ANDROID_NDK_HOME"

TestApp/set-ndk-version.sh

@@ -0,0 +1,23 @@
+#!/bin/bash
+
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License.
+
+# Set the NDK version in the android section of the build.gradle file.
+
+PROPERTY_FILE="$ANDROID_HOME/ndk-bundle/source.properties"
+
+echo "Reading ndk version from source.properties file..."
+VERSION=$(cat $PROPERTY_FILE | sed 's/ //g' | grep "Pkg.Revision" | cut -d'=' -f2)
+echo $VERSION
+
+GRADLE_FILE="./android/app/build.gradle"
+
+if [ -z $VERSION ]; then
+  echo "No NDK found in the default location. Proceeding..."
+else
+
+  # Insert ndkVersion = 'x.x.x' in the android section.
+  NDK_VERSION_LINE="ndkVersion = '$VERSION'"
+  echo "$(sed "s/android {/android {\\`echo -e '\n\r    '`$NDK_VERSION_LINE/g" "$GRADLE_FILE")" > $GRADLE_FILE
+fi

TestApp/update-npm-packages.sh

@@ -1,4 +1,7 @@
 #!/bin/bash
+
+# Update AppCenter npm packages for the TestApp
+
 set -e
 
 echo 'Removing existing appcenter* packages...'
@@ -13,32 +16,51 @@ npm pack ../appcenter-link-scripts
 echo "Installing appcenter* packages..."
 npm install appcenter*.tgz
 
-echo "workaround for macs on arm64"
-npm install react-native-fs --save --legacy-peer-deps
-
 echo "Cleanup appcenter*.tgz"
 rm appcenter*.tgz
 
 echo "Installing other packages..."
 npm install
 
-# Issue: https://github.com/react-native-community/cli/issues/1403
-# Fixed in RN 0.65: https://github.com/facebook/react-native/commit/8721ee0a6b10e5bc8a5a95809aaa7b25dd5a6043
-echo "Applying patch to react-native package that fixes build on Xcode 12.5..."
-npx patch-package
+if [ -z "$1" ] || [ "$1" == "ios" ]; then
+    if [[ "$OSTYPE" == "darwin"* && "$(uname -m)" == "arm64" ]]; then
+        echo "Workaround for macs on arm64"
+        npm install react-native-fs --save --legacy-peer-deps
+    fi
+
+    echo "Install shared framework pods..."
+    (cd ../AppCenterReactNativeShared/ios && pod install --repo-update)
+
+    echo "Running pod install and building shared framework..."
+    (cd ios && pod install --repo-update)
+fi
+
 
-echo "Running jetify to resolve AndroidX compatibility issues..."
-npx jetify
+if [ -z "$1" ] || [ "$1" == "android" ]; then
+    echo "Running jetify to resolve AndroidX compatibility issues..."
+    npx jetify
 
-echo "Updating CocoaPods repos..."
-pod repo update
+    OS_TYPE=$(uname)
+    if [[ "$OS_TYPE" == "Darwin" ]]; then
+        # macOS
+        SED_INPLACE=("sed" "-i" "")
+    else
+        # Linux and others
+        SED_INPLACE=("sed" "-i")
+    fi
 
-echo "Install shared framework pods..."
-(cd ../AppCenterReactNativeShared/ios && pod install)
+    # Remove versionName from build.gradle for AppCenterReactNativeShared
+    # to avoid build errors like:
+    # > Cannot get property 'versionName' on extra properties extension as it does not exist
+    # echo "Remove versionName from build.gradle for AppCenterReactNativeShared"
+    "${SED_INPLACE[@]}" "/buildConfigField .*VERSION_NAME/d" "../AppCenterReactNativeShared/android/build.gradle"
 
-# for testing with not released apple and android sdks, you will need to provide the storage access key
-echo "Running pod install and building shared framework..."
-(cd ios && pod install --repo-update)
+    # Remove the line "from components.release" to avoid error:
+    # > Could not get unknown property 'release' for SoftwareComponentInternal set of type org.gradle.api.internal.component.DefaultSoftwareComponentContainer.
+    "${SED_INPLACE[@]}" "/from components.release/d" "../AppCenterReactNativeShared/android/build.gradle"
 
-# workaround for macs on arm64 (uncomment when running on arm64 mac)
-# (cd ios && pod install)
+    # Move android namespaces for the AppCenter modules from build.gradle to AndroidManifest.xml
+    # to avoid build errors like:
+    # > Could not find method namespace() for arguments [com.microsoft.appcenter.reactnative.appcenter] on extension 'android' of type com.android.build.gradle.LibraryExtension.
+    bash ./use-android-manifest-namespaces.sh
+fi

TestApp/use-android-manifest-namespaces.sh

@@ -0,0 +1,85 @@
+#!/bin/bash
+
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License.
+
+# Move android namespaces for the AppCenter modules from build.gradle to AndroidManifest.xml
+
+move_namespace() {
+    # Check if the first argument is provided
+    if [ -z "$1" ]; then
+        echo "There is no android project path: move_namespace /path/to/your/android/project"
+        return 1
+    fi
+
+    PROJECT_PATH="$1"
+    BUILD_GRADLE="$PROJECT_PATH/android/build.gradle"
+    MANIFEST_XML="$PROJECT_PATH/android/src/main/AndroidManifest.xml"
+
+    # Verify if build.gradle exists
+    if [ ! -f "$BUILD_GRADLE" ]; then
+        echo "Error: build.gradle not found: $BUILD_GRADLE"
+        return 1
+    fi
+
+    # Verify if AndroidManifest.xml exists
+    if [ ! -f "$MANIFEST_XML" ]; then
+        echo "Error: AndroidManifest.xml not found: $MANIFEST_XML"
+        return 1
+    fi
+
+    # Extract namespace from build.gradle
+    NAMESPACE=$(grep -E '^\s*namespace\s*[= ]\s*["'"'"']([^"'"'"']+)["'"'"']' "$BUILD_GRADLE" | head -n 1 | awk -F'"' '{print $2}')
+    ESCAPED_NAMESPACE="${NAMESPACE//./\\.}"
+
+    if [ -z "$NAMESPACE" ]; then
+        echo "Error: Can not find namespace in build.gradle"
+        return 1
+    fi
+
+    echo "Founded namespace: $NAMESPACE"
+
+    # Determine the operating system type and configure sed command for inline editing
+    OS_TYPE=$(uname)
+    if [[ "$OS_TYPE" == "Darwin" ]]; then
+        # macOS
+        SED_INPLACE=("sed" "-i" "")
+    else
+        # Linux and others
+        SED_INPLACE=("sed" "-i")
+    fi
+
+    # Remove the namespace line from build.gradle
+    "${SED_INPLACE[@]}" "/namespace \"${ESCAPED_NAMESPACE}\"/d" "$BUILD_GRADLE"
+    # Check if the namespace is successfully deleted
+    if grep -q "^\s*namespace\s* \s*['\"]${NAMESPACE}['\"]" "$BUILD_GRADLE"; then
+        echo "Error: namespace is not deleted from build.gradle"
+        return 1
+    else
+        echo "Namespace is deleted from build.gradle"
+    fi
+
+    # Extract the current package name from AndroidManifest.xml
+    CURRENT_PACKAGE=$(grep -E '<manifest\s+package="([^"]+)"' "$MANIFEST_XML" | head -n1 | sed -E 's/.*package="([^"]+)".*/\1/')
+
+    # Update or add the package attribute in AndroidManifest.xml if it differs from the namespace
+    if [ "$CURRENT_PACKAGE" != "$NAMESPACE" ]; then
+        if grep -q 'package="' "$MANIFEST_XML"; then
+            "${SED_INPLACE[@]}" "s/package=\"[^\"]*\"/package=\"$NAMESPACE\"/" "$MANIFEST_XML"
+            echo "Updated package attribute in AndroidManifest.xml to $NAMESPACE"
+        else
+            "${SED_INPLACE[@]}" "1s/<manifest /<manifest package=\"$NAMESPACE\" /" "$MANIFEST_XML"
+            echo "Added attribute package to AndroidManifest.xml: $NAMESPACE"
+        fi
+    else
+        echo "Package attribute already matches namespace: $NAMESPACE"
+    fi
+
+    echo "Namespace successfully moved from $BUILD_GRADLE to $MANIFEST_XML"
+    return 0
+}
+
+# Move namespaces for the AppCenter modules
+move_namespace ./node_modules/appcenter
+move_namespace ./node_modules/appcenter-analytics
+move_namespace ./node_modules/appcenter-crashes