-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Usage of MSVC toolchain within images #102
Comments
Unfortunately MSVC is outside my area of knowledge so please allow us to investigate internally with the appropriate teams. |
@vrapolinario any updates on this? |
Unfortunately I don't have an update yes. |
Alright, apologies for the delay. Here's the information I got internally: (Please note this is not owned by the Windows Container team) A change in the MSVC licensing is not being actively discussed. Redistribution of the VS Build Tools is not permitted, so we should make sure that while we document how .dockerfile should install VS Build Tools for anyone wanting to create private container images, we cannot publish these images on any public container repos. On note that was raised is that GH Actions agents already have VS Build Tools on them, so if this helps with Rust CI requirements, it might be an alternative. |
1. We cannot redistribute Windows ue4-build-prerequisites due to licensing of VS Build Tools See microsoft/Windows-Containers#102 (comment) 2. For Linux, prebuilt ue4-build-prerequisites has very low value - it is trivial to be built by user
There's currently ongoing work on providing an official Rust Windows image in rust-lang/docker-rust#71. As Rust uses the MSVC toolchain as a default for compiling for Windows (https://doc.rust-lang.org/edition-guide/rust-2018/platform-and-target-support/msvc-toolchain-support.html), it needs to be included within the image.
The issue of licensing has now come up. E.g. https://devblogs.microsoft.com/cppblog/using-msvc-in-a-docker-container-for-your-c-projects/ says:
Are there any updates to that? Does that mean we can't provide an official Rust Windows image which would both help the Rust and the Windows Container community or is a reference to the VS Build tools license enough?
We were wondering because the official .NET Framework SDK image is also using the VS Build Tools (https://github.com/microsoft/dotnet-framework-docker/blob/3b2ac5bcda7603b94c0b6399355f3d0c0c1eb512/src/sdk/4.8/windowsservercore-1909/Dockerfile#L21-L30) without explicitly stating that you need a Visual Studio License to be allowed to use the official image.
The text was updated successfully, but these errors were encountered: