Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish updated Windows ue4-build-prerequisites to DockerHub #167

Closed
slonopotamus opened this issue May 20, 2021 · 2 comments
Closed

Publish updated Windows ue4-build-prerequisites to DockerHub #167

slonopotamus opened this issue May 20, 2021 · 2 comments
Assignees
@adamrehn
Labels
enhancement New feature or request

Comments

@slonopotamus
Copy link
Collaborator

#144 has severely reduced size of ue4-build-prerequisites, so it looks like it is worth uploading new images. I don't have write access to DockerHub, so assigning this issue to @adamrehn.

Note that this is blocked by jberezanski/ChocolateyPackages#105, so we first need to wait until fixed version of vcredist-all is approved in Chocolatey.
@slonopotamus slonopotamus added the enhancement New feature or request label May 20, 2021
@slonopotamus slonopotamus changed the title Publish new ue4-build-prerequisites to DockerHub Publish updated Windows ue4-build-prerequisites to DockerHub May 21, 2021
@slonopotamus
Copy link
Collaborator Author

Okaaaay, I think we have licensing issues with ue4-build-prerequisites. ue4-build-prerequisites contains VS Build Tools and MS says we're not allowed to redistribute them.

@slonopotamus
Copy link
Collaborator Author

slonopotamus commented Jun 17, 2021 •
edited
Loading

We're not going to publish Windows ue4-build-prerequisites images for the reason described above.

slonopotamus added a commit to slonopotamus/ue4-docker that referenced this issue Jun 25, 2021
@slonopotamus
Remove --pull-prerequisites flag
d4a2b4b 
Motivation:
1. We're not allowed to publish ue4-build-prerequisites for Windows because of VS Build Tools licensing.
See adamrehn#167 (comment)
2. ue4-build-prerequisites for Linux tends to become outdated, and is trivial to be built by user.
See adamrehn#179 (comment)

Additionally, fix ue4-build-prerequisites to respect UE4DOCKER_TAG_NAMESPACE env variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamrehn adamrehn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slonopotamus @adamrehn