This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
StatefulHello passes npm run test #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing to set `0`, so `StatefulHello` component can pass the same tests as `Hello` component
gasparsigma
suggested changes
Feb 16, 2019
| @@ -280,7 +280,7 @@ interface State { | |||
| class Hello extends React.Component<Props, State> { | |||
| constructor(props: Props) { | |||
| super(props); | |||
| this.state = { currentEnthusiasm: props.enthusiasmLevel || 1 }; | |||
| this.state = { currentEnthusiasm: props.enthusiasmLevel == null ? 1 : props.enthusiasmLevel }; | |||
There was a problem hiding this comment.
Enthusiasm level cannot be null. It can be number or undefined.
You can check for strict comparison === undefined instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we don't run tests on
StatefulHelloon the tutorial, it is intended by the authors to pass the same tests as theHellocomponent. Thus we need to stop convertingenthusiasmLevelto1when0is passed in.