Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Use real Create React App #227

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Timer
Copy link

@Timer Timer commented Oct 30, 2018

Create React App 2.1 now supports TypeScript. This updates the repository to use mainline Create React App instead of a fork.

@msftclas
Copy link

msftclas commented Oct 30, 2018

CLA assistant check
All CLA requirements met.

@JLarky
Copy link

JLarky commented Oct 30, 2018

@Timer I think this PR is great. But I would still add to README limitations of current implementation of Typescript support and provided link to wmonk fork as something that might be used in advanced cases.

@Timer
Copy link
Author

Timer commented Oct 31, 2018

@JLarky the only limitations are namespaces, const enums, and type casting via <type>.

Namespaces are a legacy concept predating ES Modules. I wouldn't be surprised if they were removed from TypeScript or deprecated.
Const enums are a micro-optimization.
Type casting via <type> probably isn't used much in practice, and can be replaced with var as type.

I'd be more than happy to add these limitations to this PR if a maintainer requests, but they're detailed in Create React App and probably unnecessary to explain to a beginner.

@JLarky
Copy link

JLarky commented Oct 31, 2018

@Timer this doesn't change the fact that you can have code that relies on those features (or on baseUrl and paths) and this is going to be breaking change.

@Timer
Copy link
Author

Timer commented Oct 31, 2018

Code that relies on these features can be easily migrated since you have full control over it. Also, baseUrl and paths are disabled for good reason and we'll be exploring support in the future.

@JLarky
Copy link

JLarky commented Oct 31, 2018 via email

@Timer
Copy link
Author

Timer commented Oct 31, 2018

I'd be more than happy to take a look if you're unable to get it working.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants