-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use real Create React App #227
base: master
Are you sure you want to change the base?
Conversation
@Timer I think this PR is great. But I would still add to README limitations of current implementation of Typescript support and provided link to wmonk fork as something that might be used in advanced cases. |
@JLarky the only limitations are namespaces, const enums, and type casting via Namespaces are a legacy concept predating ES Modules. I wouldn't be surprised if they were removed from TypeScript or deprecated. I'd be more than happy to add these limitations to this PR if a maintainer requests, but they're detailed in Create React App and probably unnecessary to explain to a beginner. |
@Timer this doesn't change the fact that you can have code that relies on those features (or on baseUrl and paths) and this is going to be breaking change. |
Code that relies on these features can be easily migrated since you have full control over it. Also, |
Should I provide you with gitlab credentials so you can upgrade my code? I
hope this doesn't sound too ridiculous for you.
…On Tue, Oct 30, 2018, 18:33 Joe Haddad ***@***.*** wrote:
Code that relies on these features can be easily migrated since you have
full control over it. Also, baseUrl and paths are disabled for good
reason and we'll be exploring support in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#227 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAbcmfYRnz5Dz80-oXg_VW2FA4KDHx0ks5uqP3egaJpZM4YBJ-m>
.
|
I'd be more than happy to take a look if you're unable to get it working. |
Create React App 2.1 now supports TypeScript. This updates the repository to use mainline Create React App instead of a fork.